Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use promote_rule not promote_type #73

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

oxinabox
Copy link
Contributor

Solves the ambiguity reported in https://discourse.julialang.org/t/having-trouble-implementating-a-tables-jl-row-table-when-using-badukgoweiqitools-dataframe-tbl-no-longer-works/63622
cc @xiaodaigh

I have a feeling that one is not mean to define promote_type directly.
(Will be making a PR to Julia to document that and then find out if i am wrong via Cunningham's law)

@xiaodaigh
Copy link

Thanks. I was mulling whether to report this to WeakRefStrings or DataFrames. But I wanted to push it for a couple of weeks.

@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #73 (ca27041) into main (ec317cc) will increase coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   81.48%   81.55%   +0.07%     
==========================================
  Files           3        3              
  Lines        1145     1144       -1     
==========================================
  Hits          933      933              
+ Misses        212      211       -1     
Impacted Files Coverage Δ
src/inlinestrings.jl 90.87% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec317cc...ca27041. Read the comment docs.

Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and clarification to Base! (failure on nightly is unrelated; I'll take a look at it separately)

@quinnj quinnj merged commit d021f5c into JuliaData:main Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants