Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version check workaround for JuliaLang/julia#29970 #47

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Version check workaround for JuliaLang/julia#29970 #47

merged 1 commit into from
Mar 20, 2019

Conversation

lcw
Copy link
Contributor

@lcw lcw commented Mar 19, 2019

The workaround for JuliaLang/julia#29970 causes newer versions of Julia
to hang in the precompilation step for TypedTables.

Since JuliaLang/julia#29970 has been addressed in JuliaLang/julia#30577
the code is avoided in newer versions of Julia.

@lcw
Version check workaround for JuliaLang/julia#29970
be8224b 
The workaround for JuliaLang/julia#29970 causes newer versions of Julia
to hang in the precompilation step for TypedTables.

Since JuliaLang/julia#29970 has been addressed in JuliaLang/julia#30577
the code is avoided in newer versions of Julia.
@coveralls
Copy link

Coverage Status

Coverage increased (+5.9%) to 67.974% when pulling be8224b on lcw:hang into 5142f30 on FugroRoames:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+5.9%) to 67.974% when pulling be8224b on lcw:hang into 5142f30 on FugroRoames:master.

@codecov-io
Copy link

Codecov Report

Merging #47 into master will increase coverage by 5%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
+ Coverage   62.06%   67.06%   +5%     
=======================================
  Files           6        6           
  Lines         485      498   +13     
=======================================
+ Hits          301      334   +33     
+ Misses        184      164   -20
Impacted Files Coverage Δ
src/TypedTables.jl 75% <100%> (-25%) ⬇️
src/FlexTable.jl 68% <0%> (-7.68%) ⬇️
src/Table.jl 76% <0%> (-0.05%) ⬇️
src/properties.jl 73.78% <0%> (+4.91%) ⬆️
src/show.jl 50% <0%> (+14.65%) ⬆️
src/columnops.jl 70.83% <0%> (+21.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5142f30...be8224b. Read the comment docs.

4 similar comments
@codecov-io
Copy link

Codecov Report

Merging #47 into master will increase coverage by 5%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
+ Coverage   62.06%   67.06%   +5%     
=======================================
  Files           6        6           
  Lines         485      498   +13     
=======================================
+ Hits          301      334   +33     
+ Misses        184      164   -20
Impacted Files Coverage Δ
src/TypedTables.jl 75% <100%> (-25%) ⬇️
src/FlexTable.jl 68% <0%> (-7.68%) ⬇️
src/Table.jl 76% <0%> (-0.05%) ⬇️
src/properties.jl 73.78% <0%> (+4.91%) ⬆️
src/show.jl 50% <0%> (+14.65%) ⬆️
src/columnops.jl 70.83% <0%> (+21.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5142f30...be8224b. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #47 into master will increase coverage by 5%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
+ Coverage   62.06%   67.06%   +5%     
=======================================
  Files           6        6           
  Lines         485      498   +13     
=======================================
+ Hits          301      334   +33     
+ Misses        184      164   -20
Impacted Files Coverage Δ
src/TypedTables.jl 75% <100%> (-25%) ⬇️
src/FlexTable.jl 68% <0%> (-7.68%) ⬇️
src/Table.jl 76% <0%> (-0.05%) ⬇️
src/properties.jl 73.78% <0%> (+4.91%) ⬆️
src/show.jl 50% <0%> (+14.65%) ⬆️
src/columnops.jl 70.83% <0%> (+21.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5142f30...be8224b. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #47 into master will increase coverage by 5%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
+ Coverage   62.06%   67.06%   +5%     
=======================================
  Files           6        6           
  Lines         485      498   +13     
=======================================
+ Hits          301      334   +33     
+ Misses        184      164   -20
Impacted Files Coverage Δ
src/TypedTables.jl 75% <100%> (-25%) ⬇️
src/FlexTable.jl 68% <0%> (-7.68%) ⬇️
src/Table.jl 76% <0%> (-0.05%) ⬇️
src/properties.jl 73.78% <0%> (+4.91%) ⬆️
src/show.jl 50% <0%> (+14.65%) ⬆️
src/columnops.jl 70.83% <0%> (+21.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5142f30...be8224b. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Mar 19, 2019 •
edited
Loading

Codecov Report

Merging #47 into master will increase coverage by 5%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
+ Coverage   62.06%   67.06%   +5%     
=======================================
  Files           6        6           
  Lines         485      498   +13     
=======================================
+ Hits          301      334   +33     
+ Misses        184      164   -20
Impacted Files Coverage Δ
src/TypedTables.jl 75% <100%> (-25%) ⬇️
src/FlexTable.jl 68% <0%> (-7.68%) ⬇️
src/Table.jl 76% <0%> (-0.05%) ⬇️
src/properties.jl 73.78% <0%> (+4.91%) ⬆️
src/show.jl 50% <0%> (+14.65%) ⬆️
src/columnops.jl 70.83% <0%> (+21.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5142f30...be8224b. Read the comment docs.

@andyferris
Copy link
Member

Awesome, thanks @lcw

@andyferris andyferris merged commit 97fd36e into JuliaData:master Mar 20, 2019
@giordano giordano mentioned this pull request May 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyferris andyferris andyferris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lcw @coveralls @codecov-io @andyferris