Improve copy of SubDataFrame and DataFrameRow #1564
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nalimilan This is a follow up to #1534, and should be merged if the other is merged (I separate it as we have enough of changes there).
What it does:
copy
forSubDataFrame
to ensure that it returns aDataFrame
in the future (this is the same functionality as we have but with a syntax taking into account future changes togetindex
that are currently in deprecation period)copy
forDataFrameRow
Actually the second point is crucial as it is a simple change that is consistent with #1534 logic but shows one important thing. Should returned
NamedTuple
have minimal (narrowest) second parametric argument (type specification). This is what is implemented now.Or it should have a wide type specification consistent with
eltype
ofDataFrame
column.The difference is that either:
NamedTuple
is passed to a function and it might be a bit faster to create (not 100% sure though);NamedTuple
created from a row of a givenDataFrame
will have the same concrete type.I am not fully clear what is better (I have implemented first, but I have the feeling that maybe the second approach is better).