Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable -Wunused-but-set-variable on aarch64-apple-darwin #296

Merged
merged 2 commits into from
Apr 22, 2023
Merged

Disable -Wunused-but-set-variable on aarch64-apple-darwin #296

merged 2 commits into from
Apr 22, 2023

Conversation

staticfloat
Copy link
Member

No description provided.

@giordano
Copy link
Contributor

If there's only a warning, how about disabling only that?

@DilumAluthge DilumAluthge mentioned this pull request Apr 22, 2023
Merged
@DilumAluthge DilumAluthge reopened this Apr 22, 2023
@DilumAluthge DilumAluthge changed the title Disable -Werror on aarch64 macOS Disable -Wunused-but-set-variable on aarch64-apple-darwin Apr 22, 2023
@DilumAluthge
Copy link
Member

Do we need to change the format of the MAKE_FLAGS column? Right now, the entries in MAKE_FLAGS are comma-separated, but obviously this will be a problem if the entries themselves contain commas.

@DilumAluthge DilumAluthge self-requested a review April 22, 2023 05:02
@staticfloat
Copy link
Member Author

Actually, I don’t want a comma I want a space. I just havent figured out how to do it yet. :P

@giordano
Copy link
Contributor

I presume you already tried quotes?

@staticfloat staticfloat force-pushed the sf/werror_on_aarch64_macos branch 8 times, most recently from b0e9d96 to 54f6037 Compare April 22, 2023 18:08
@staticfloat
Copy link
Member Author

staticfloat commented Apr 22, 2023 •
edited
Loading

I struggled for about half an hour trying to shoe-horn multiple values into the JL_CFLAGS make flag here, and couldn't do it. I'm just going to merge a lack of -Werror and we can improve things later.

Right now, the entries in MAKE_FLAGS are comma-separated, but obviously this will be a problem if the entries themselves contain commas.

The issue here is that I want JL_CFLAGS to contain two flags; so I need a space separator. But there are too many layers of bash parsing going on, the values get separated into two separate arguments to make. :(

@staticfloat
Disable -Wunused-but-set-variable on aarch64-apple-darwin
dfe1753 
The new `clang` interacts badly with LLVM headers, giving the fatal
error message:

```
/Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-P2C257CXGN.0/build/default-honeycrisp-P2C257CXGN-0/julialang/julia-master/usr/include/llvm/ADT/DenseMap.h:129:16: error: variable 'NumEntries' set but not used [-Werror,-Wunused-but-set-variable]
      unsigned NumEntries = getNumEntries();
               ^
```

Example: https://buildkite.com/julialang/julia-master/builds/23068#0187a57a-fa1f-45ca-8811-a0637827e3da/438-895
@staticfloat
sign treehashes
60e2463
@staticfloat staticfloat merged commit 9d3b040 into main Apr 22, 2023
@staticfloat staticfloat deleted the sf/werror_on_aarch64_macos branch April 22, 2023 18:17
@giordano giordano mentioned this pull request Mar 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DilumAluthge DilumAluthge Awaiting requested review from DilumAluthge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@staticfloat @giordano @DilumAluthge