Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update macos stdlib pkgimage checksums after codesigning #292

Merged
merged 5 commits into from
Apr 3, 2023

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Mar 31, 2023

@IanButterworth
Copy link
Member Author

@staticfloat I don't see this being called in build aarch64-apple-darwin but I do see the stdlibs being codesigned there.

I believe it needs to happen there otherwise the test workers won't be able to load the stdlib caches

@IanButterworth
Copy link
Member Author

@IanButterworth
Copy link
Member Author

I'm giving that a go here JuliaLang/julia#49132

@staticfloat
Copy link
Member

I don't see this being called in build aarch64-apple-darwin but I do see the stdlibs being codesigned there.

That codesigning is worthless, as the build step doesn't have access to codesigning keys, so they're all just ad-hoc signed (which happens anyway when you link with ld on newer macOS machines). I have a lingering PR to remove those steps from the build process: JuliaLang/julia#48545

The test workers re-sign everything when they download them, right here:

.buildkite/utilities/macos/codesign.sh "${JULIA_INSTALL_DIR}"
. You can see the outputs in the test job of this PR right here: https://buildkite.com/julialang/julia-buildkite/builds/1296#0187394f-53cc-4067-959a-0bce9ff5fb5e/492-575

@IanButterworth

This comment was marked as resolved.

@IanButterworth
Copy link
Member Author

Seems to have worked? Just waiting for a x86 MacOS runner

@IanButterworth
Copy link
Member Author

Both macos runners passed. Windows failed tests which I guess is unrelated. i retried.

Also the .dmg uploaded works locally

@staticfloat
Copy link
Member

Looks good to me!

@staticfloat staticfloat merged commit 2ef3b4c into JuliaCI:main Apr 3, 2023
@IanButterworth IanButterworth deleted the ib/amend_pkgimg_checksums branch April 3, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants