Change order of function definition in matrix multiplication code #833
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix for a bug introduced in #814 . In some circumstances generated functions from
matrix_multiply_add.jl
don't see methods ofgen_by_access
anduplo_access
defined inmatrix_multiply.jl
(generated functions somehow get instantiated in an earlier world age). This moves all required methods so that they are defined earlier. Unfortunately I don't know how to make a test for this.Thanks @krzysztofrzecki for discovering this problem!