Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test arithmetic_closure against concrete types #1237

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jan 24, 2024

On Julia nightly,

julia> subtypes(AbstractFloat)
5-element Vector{Any}:
 BigFloat
 Core.BFloat16
 Float16
 Float32
 Float64

and Core.BFloat16 does not have one defined for itself, which was leading to test failures. It's better to be explicit in the types that we test against, which are known to work.

Copy link
Collaborator

@mateuszbaran mateuszbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea, though not having one for BFloat16 seems to be a bug in Julia? Or is there some justification for not having it?

@jishnub
Copy link
Member Author

jishnub commented Jan 24, 2024

I'm not sure, but given that it's in Core and isn't public, it's probably some internal type. Perhaps it's best to not rely on its properties.

@jishnub jishnub merged commit 9e9ea02 into JuliaArrays:master Jan 25, 2024
22 of 29 checks passed
@jishnub jishnub deleted the testfloatsubtypes branch January 25, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants