Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to PrecompileTools #1187

Merged
merged 3 commits into from
Oct 28, 2023
Merged

Conversation

IanButterworth
Copy link
Contributor

@IanButterworth IanButterworth commented Jul 19, 2023

Fixes #1184
Fixes #1182
Closes #1183

@timholy would you mind helping me figure out the commented out ones?

@IanButterworth IanButterworth force-pushed the ib/precompiletools branch 3 times, most recently from ba4c91f to eacdf46 Compare July 19, 2023 01:14
Copy link
Member

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

src/precompile.jl Outdated Show resolved Hide resolved
src/precompile.jl Outdated Show resolved Hide resolved
@IanButterworth
Copy link
Contributor Author

ERROR: LoadError: MethodError: no method matching zeros(::StaticArraysCore.SVector{2, Float32})

Closest candidates are:
  zeros(::Type{SA}) where {T, SA<:(StaticArraysCore.StaticArray{<:Tuple, T})}
   @ StaticArrays ~/work/StaticArrays.jl/StaticArrays.jl/src/arraymath.jl:2
  zeros(::Type{SA}) where SA<:(StaticArraysCore.StaticArray)
   @ StaticArrays ~/work/StaticArrays.jl/StaticArrays.jl/src/arraymath.jl:1
  zeros(::Type{T}, Union{Integer, AbstractUnitRange}...) where T
   @ Base array.jl:630

Comment on lines 19 to 20
zeros(y)
zeros(x)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timholy see error above. I guessed

Suggested change
zeros(y)
zeros(x)
zeros(T, y)
zeros(T, x)

but hit

ERROR: LoadError: MethodError: no method matching zeros(::Type{Float32}, ::StaticArraysCore.SVector{2, Float32})

Closest candidates are:
  zeros(::Type{T}, ::Union{Integer, AbstractUnitRange}...) where T
   @ Base array.jl:580
  zeros(::Type{T}, ::Tuple{}) where T
   @ Base array.jl:588
  zeros(::Type{T}, ::Tuple{Vararg{Integer, N}}) where {T, N}
   @ Base array.jl:583
  ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoot, should be zero not zeros. Sorry 'bout that!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np. thanks

Co-Authored-By: Tim Holy <[email protected]>
Copy link
Member

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case I don't notice, someone should merge this when tests pass (nightly is now failing for a different reason having to do with nicer @code_llvm output; if one snips after the first \n I think that will fix that bug).

@KnutAM
Copy link
Contributor

KnutAM commented Sep 10, 2023

In case I don't notice, someone should merge this when tests pass

I just scrolled by and figured I could give a ping: @timholy

@IanButterworth
Copy link
Contributor Author

Can someone rerun nightly CI

@timholy timholy closed this Sep 10, 2023
@timholy timholy reopened this Sep 10, 2023
@hyrodium
Copy link
Collaborator

The CI failure on nightly seems unrelated to this PR.

Copy link
Collaborator

@hyrodium hyrodium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hyrodium hyrodium merged commit 61ed9cd into JuliaArrays:master Oct 28, 2023
40 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to PrecompileTools.jl ? Precompile failures on julia nightly
4 participants