Improve type inference for adjoint/transpose of nested matrices #1181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR special-cases the return-types of the
adjoint
andtranspose
forSMatrix
andMMatrix
. This isn't ideal, but currently Julia doesn't infer the return types of certain recursive calls with changing types, and this PR helps with type-inference in such cases.An example (using this PR):
Whereas, on master,