Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature importances support for tuned models #213

Merged
merged 2 commits into from
Mar 24, 2024
Merged

add feature importances support for tuned models #213

merged 2 commits into from
Mar 24, 2024

Conversation

OkonSamuel
Copy link
Member

@OkonSamuel OkonSamuel commented Mar 22, 2024

This PR adds MLJModelInterface.feature_importances support for TunedModel.

Now calling MLJModelInterface.feature_importances on a TunedModel object just returns the feature importances for the wrapped model. For cases where the model wrapped by the TunedModel object doesn't support feature importance, nothing is returned.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.53%. Comparing base (c081bd0) to head (b9d8c01).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #213      +/-   ##
==========================================
+ Coverage   87.42%   87.53%   +0.11%     
==========================================
  Files          13       13              
  Lines         660      666       +6     
==========================================
+ Hits          577      583       +6     
  Misses         83       83              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OkonSamuel OkonSamuel requested a review from ablaom March 22, 2024 17:13
Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thank you.

@OkonSamuel OkonSamuel merged commit ac447ec into dev Mar 24, 2024
4 checks passed
This was referenced Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants