Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crystal field calculation #22

Merged
merged 32 commits into from
Mar 9, 2021
Merged

Conversation

janssenhenning
Copy link
Contributor

@janssenhenning janssenhenning commented Feb 22, 2021

This pull request implements a small tool to calculate crystal field coefficients from data produced by Fleur (Max5) or KKR.
Moved from a private repository of mine to be able to be used in aiida-fleur

TODO:

  • docs are failing in the actions because it can't call latex to resolve the ..math: directive in the class docstring
  • tests

EDIT: The first issue is fixed by installing texlive in the docs actions (It makes this the longest running job ~2 min but I think its okay since pre-commit also takes 2 minutes)

@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #22 (8e62cbb) into develop (7adbb8e) will increase coverage by 0.83%.
The diff coverage is 90.88%.

@@             Coverage Diff             @@
##           develop      #22      +/-   ##
===========================================
+ Coverage    67.60%   68.43%   +0.83%     
===========================================
  Files           62       64       +2     
  Lines         9996    10367     +371     
===========================================
+ Hits          6758     7095     +337     
- Misses        3238     3272      +34     

Restrict bokeh to version 1.4 (adapted from move_aiida_fleur_methods branch)
@janssenhenning janssenhenning merged commit 78b1cff into develop Mar 9, 2021
@janssenhenning janssenhenning deleted the crystal_field_calculation branch March 9, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant