Support magnetic moment definitions in inpgen IO #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be added to the atomsites if a sequence of dicts or namedtuples under the name `magnetic_moment` is passed (not normal tuples) and can be 'up', 'down', a single float or a list of three floats
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #213 +/- ##
===========================================
+ Coverage 84.72% 84.78% +0.06%
===========================================
Files 135 135
Lines 25299 25420 +121
===========================================
+ Hits 21434 21552 +118
- Misses 3865 3868 +3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #197
Support not yet added for roundtripping magnetic moments from the inp.xml