Adjust XML getter names #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #208 +/- ##
===========================================
- Coverage 86.92% 86.90% -0.02%
===========================================
Files 133 133
Lines 24593 24602 +9
===========================================
+ Hits 21378 21381 +3
- Misses 3215 3221 +6 |
These names now exactly match the names of the calcfunctions on the FleurinpData class
for more information, see https://pre-commit.ci
05b1aa9
to
22eba9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underscore before data is removed. This is done since the new names match exactly the methods on the FleurinpData class in aiida-fleur