Rename DataFactory & TransportFactory to include their Module name #66
Comments
JoaquimLey
added a commit
that referenced
this issue
Oct 9, 2018
- App now runs again (dagger was broken with missing Provides) - Renamed Mapper to avoid confusion on repeated class names #66.
JoaquimLey
added a commit
that referenced
this issue
Oct 17, 2018
) * Scaffold sharedpreferences module - Attach to store implemetnation - Mock data currently being returned Some housekeeping. * Small configurations for CI Still not working, wanted to make mock work with debug but variants still compain. * Test removing ViewModelModule * Ci why you no work? * Fix lints on CI * Working stuff for CI * housekeeping mobile-ui/build.gradle Had to make some changtes while debuging CI fails. This change still makes sense IMO. #69 * Rename data package to include project name #69 * Remove unecessary .gitignore from other packages Maintenece commit, not really related to this branch feature. * Manifest cleanup and format * Scaffold stuff for stream episode 17 Some basic ideas just so I know what I'm supposed to continue, a lot of TODOs so lint warns me. For #17 Ref #69 * Housekeeping from previous commit * Fix typo in readme Changed the copy on the stream log section * Include kotlinx.serialization experimental library for sharedPrefs This will be included in the stblib from Kotlin 1.3. #17, #69 * Make SharedPrefTransport model @kotlinx.serialization.Serializable Also, fixes and issue where the String was default to which made the serialization fail: - Kotlin/kotlinx.serialization#115 #17, #69 * SharedPrefMapper tests - Created necessary factory/mock data classes for the SharedPref module Named the mock classes with the SharedPref prefix for #66 #17 #69 * Initial tests for FrameworkLocalStorageImpl Lacking SharedPreferences test setup - Will probably need to move all the Android test libs to androidx variant. #17 #69 * Include stream episode PR to README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With the current repeated names, it becomes really hard to import the correct one since some of these modules have dependencies btw'em.
E.g
DomainDataFactory->DomainDataFactoryThe text was updated successfully, but these errors were encountered: