Added playback speed to the video player #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great! Thanks for taking a stab at it. I'll get it all built and distributed. |
|
This addresses #9 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Jman012 - I use this app quite a bit and figured I'd take a stab a quick win. Playback speed seemed like something I'd use, plus you have an enhancement logged for it. I noodled about adding the selected playback speed to UserDefaults like you're doing with resolution but thought it might be kind of annoying if I came back to the app after some time and wasn't expecting it.
I'm mainly a web developer so I may be doing something dumb here (particularly with the layoutIfNeeded call) but it's the only way I could get the control to show up the first time the playback controls are displayed.