Update Linux support to 0.0.13 #288

sarnex · 2016-04-21T23:36:44Z

Code heavily based on @Francesco149's original PR, with line numbers updated.

Signed-off-by: Nick Sarnie [email protected]

His original instructions are below, with slight modification:
Make sure you have at least node v5



cd
mkdir discord
cd discord

# Install discord in /opt/
wget https://discordapp.com/api/download/canary?platform=linux&format=tar.gz
tar -xzvf discord-canary-0.0.3.tar.gz
sudo cp -r DiscordCanary /opt/
sudo ln -s /opt/DiscordCanary/DiscordCanary /usr/bin/discord

# Install BetterDiscord
git clone https://github.com/sarnex/BetterDiscordApp.git
mv BetterDiscordApp BetterDiscord
cp BetterDiscord/Installers/Node/* .
cp BetterDiscord/splice .
npm install asar wrench
sudo ./install.sh

brawaru · 2016-04-21T23:46:32Z

NodeInstaller/index.js

+ _functionCallSplice = 507;
+ _functionSplice = 580;
+ _discordPath = "/opt/DiscordCanary/resources";
+ // not sure where the .deb install, and most people are going to 


AFAIK *.deb file installs in /usr/share/discord-canary

The original required the user to install in /opt, and not everyone is on Debian or Ubuntu, so I'm inclined to leave that for now. I don't want to look like I'm taking responsibility for this code, I just updated the line numbers for 0.0.3.

brawaru · 2016-04-22T00:01:45Z

Some fixes for script :)

cd

# Move dir if exists
oldTime=$(date +"%H-%M-%S.%d-%m-%y")
mv discord "discord.${oldTime}.old"

# And.. Create new!
mkdir discord
cd discord

# Install discord in /opt/
wget "https://discordapp.com/api/download/canary?platform=linux&format=tar.gz" -O discord-canary.tar.gz
tar -xzvf discord-canary.tar.gz
sudo cp -r DiscordCanary /opt/
sudo ln -s /opt/DiscordCanary/DiscordCanary /usr/bin/discord

# Install BetterDiscord
git clone https://github.com/sarnex/BetterDiscordApp.git
mv BetterDiscordApp BetterDiscord
cp BetterDiscord/NodeInstaller/* .
cp BetterDiscord/splice .
npm install asar wrench
sudo ./install.sh

cd

To uninstall Discord:

sudo rm -f $(which discord)
sudo rm -rf /opt/DiscordCanary/

Francesco149 · 2016-04-22T07:55:07Z

ah thanks for updating my pull request, was too busy to work on it

mkody · 2016-04-24T19:43:29Z

Works fine for me!

I needed to change the _discordPath in the NodeInstaller/index.js file since the AUR package for Discord-Canary uses /opt/discord-canary/.
But it looks like this path is not consistent between distributions. But for Arch, someone might just add a patch during installation if they make a AUR package, if needed 👍

sarnex · 2016-04-26T19:31:01Z

Still works with no changes on version 0.4 and 0.5

brawaru · 2016-05-03T19:34:05Z

Not works on newest 0.0.6 version :(

sarnex · 2016-05-03T22:12:11Z

@DaFri-Nochiterov should be fixed now

I've also cleaned up the PR a good bit.

brawaru · 2016-05-04T06:26:39Z

@sarnex, yes, this works. Thanks.

brawaru · 2016-05-04T19:34:34Z

Again. Not works on 0.0.7 version.

Now with Exception:

Uncaught Exception:
SyntaxError: Unexpected token ;
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:387:25)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Object.<anonymous> (/opt/DiscordCanary/resources/electron.asar/browser/init.js:184:8)
    at Module._compile (module.js:413:34)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)

sarnex · 2016-05-04T23:11:55Z

@DaFri-Nochiterov fixed again, hopefully they leave index.js alone in the future. If it happens again, I'll look for a better solution than hardcoding line numbers which is done in the official installer.

mkody · 2016-05-06T09:36:30Z

@sarnex You should definitely look for a better solution, because I'm pretty sure the index.js will change a lot in the near future.

sarnex · 2016-05-08T01:31:08Z

I've rewritten the linux installer to not use hardcoded line numbers. It should not break now unless they remove the two lines I'm searching for, which I don't expect.

mkody · 2016-05-10T21:06:41Z

And it works fine on just-released 0.0.8! 👍

brawaru · 2016-05-14T01:11:17Z

Emoticons no longer works in this version

mkody · 2017-01-11T16:09:07Z

Yup, it is still needed. #436 should fix it.

simoniz0r · 2017-01-11T16:33:35Z

Any chance of all of that getting merged into this PR? I'd rather not go through all of that every time I install BetterDiscord.

sarnex · 2017-01-11T17:34:25Z

I merged #436 into my PR and rebased.

…

On Wed, Jan 11, 2017 at 11:33 AM, simoniz0r ***@***.***> wrote: Any chance of all of that getting merged into this PR? I'd rather not go through all of that every time I install BetterDiscord. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#288 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGvNDI9trwIK0AozKMbTuRu-9RSjJVp-ks5rRQRggaJpZM4INLQo> .

simoniz0r · 2017-01-11T18:26:46Z

Thank you so much!

magiruuvelvet · 2017-01-26T00:51:32Z

Still works with canary 0.0.14 👍
I didn't tested the Linux PTB and Stable client. I prefer Canary 😄

mkody · 2017-01-26T07:35:17Z

I guess we should change the path in js/main.js as well if we rebase on recent commits.

diff --git a/js/main.js b/js/main.js
index 4ee8bea..3f1a5d9 100644
--- a/js/main.js
+++ b/js/main.js
@@ -13,7 +13,7 @@
     let __fs = window.require("fs");
     let __process = window.require("process");
     let __platform = __process.platform;
-    let __dataPath = (__platform === 'win32' ? __process.env.APPDATA : __platform === 'darwin' ? __process.env.HOME + '/Library/Preferences' : '/var/local') + '/BetterDiscord/';
+    let __dataPath = (__platform === 'win32' ? __process.env.APPDATA : __platform === 'darwin' ? __process.env.HOME + '/Library/Preferences' : process.env.HOME + '/.config') + '/BetterDiscord/';
 
 
     let __data = {};

simoniz0r · 2017-01-26T12:13:03Z

Could you also please merge #435 into this PR? I had to create a script that deletes /home/user/.config/bdstorage.json before launching BetterDiscord otherwise it complains that /home/user/.config/BetterDiscord//bdStorage.json doesn't exist, and gives me a javascript error that locks up the whole app.

sarnex · 2017-01-26T16:45:11Z

I merged it.

…

On Thu, Jan 26, 2017 at 7:13 AM, simoniz0r ***@***.***> wrote: Could you also please merge #435 <#435> into this PR? I had to create a script that deletes /home/user/.config/bdstorage.json before launching BetterDiscord otherwise it complains that /home/user/.config/ BetterDiscord//bdStorage.json doesn't exist, and gives me a javascript error that locks up the whole app. [image: Javascript error] <https://camo.githubusercontent.com/e3d814ae6a97fc34c7d92b78e47782ba95ec6d5b/687474703a2f2f692e696d6775722e636f6d2f346a68757a32452e706e67> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#288 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGvNDM6Y-qkJd1cWNiSM7eWiyQhmX5XFks5rWI3QgaJpZM4INLQo> .

magiruuvelvet · 2017-01-27T09:02:37Z

And another update. Still works with 0.0.15 👍

dddlr · 2017-01-27T09:20:23Z

@magiruuvelvet I hope you’re not going to keep this up every day, considering the new update schedule. 😜

Signed-off-by: Nick Sarnie <[email protected]>

Change linux path to use the $HOME/.config folder

Arzte · 2017-01-30T13:53:23Z

Canary it set to build on each new push to the master branch, just as an FYI.

simoniz0r · 2017-02-04T13:52:01Z

I don't know if you've seen this, but Ckath made a script that can install BetterDiscord to any directory... might be of some use to you.
https://github.com/Ckath/Discord-stuff/blob/master/scripts/tape.sh

sarnex · 2017-02-04T18:40:14Z

This is basically just doing what the BetterDiscord installer does in a script, there's no way for it to be merged but maybe it's easier to use. I recommend following the instructions here.

…

On Sat, Feb 4, 2017 at 8:52 AM, simoniz0r ***@***.***> wrote: I don't know if you've seen this, but Ckath made a script that can install BetterDiscord to any directory... might be of some use to you. https://github.com/Ckath/Discord-stuff/blob/master/scripts/tape.sh — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#288 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGvNDNRzjwu6NDR1PvfPWzIPI4vPEXNdks5rZIKDgaJpZM4INLQo> .

simoniz0r · 2017-02-04T18:56:40Z

I would think the fact that it allows any directory to be used is enough, but shrug

sarnex · 2017-02-04T18:59:21Z

It only has to be /opt for the install, you can move Discord after.

…

On Sat, Feb 4, 2017 at 1:56 PM, simoniz0r ***@***.***> wrote: I would say the fact that it allows any directory to be used is enough, but ¯_(ツ)_/¯ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#288 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGvNDOwvjBv7-jHQKdglX6FAjwvhhK1gks5rZMnqgaJpZM4INLQo> .

simoniz0r · 2017-02-04T19:24:09Z

Sure, but that's not ideal. That is not the default install location for the .deb package. Also, with PTB and Stable being released on Linux, tape.sh makes installing BetterDiscord to those Discord versions possible without having to move them to /opt/DiscordCanary/ first.

Jiiks · 2017-02-10T14:01:03Z

Maybe it's time to merge this o-o

mkody · 2017-02-10T14:07:37Z

Woo!
You should keep an eye on the fact that we're not using /var/local anymore, but ~/.config.
This includes (at least) in v2/lib/core.js: installPath and dataPath, and injs/main.js: __dataPath

sarnex · 2017-02-10T16:17:23Z

we did it boys, i dont mind maintaining the linux portion but please use this PR for that

…

On Fri, Feb 10, 2017 at 9:07 AM, Kody ***@***.***> wrote: Woo! You should keep an eye on the fact that we're not using /var/local anymore, but ~/.config. This includes (at least) in v2/lib/core.js: installPath and dataPath, and injs/main.js: for __dataPath — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#288 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGvNDNKtBTEQDtf4QGw-sDobvoFTkmb-ks5rbG8qgaJpZM4INLQo> .

brawaru reviewed Apr 21, 2016
View reviewed changes

sarnex changed the title ~~Update Linux support to 0.0.3~~ Update Linux support to 0.0.4 Apr 26, 2016

sarnex changed the title ~~Update Linux support to 0.0.4~~ Update Linux support to 0.0.5 Apr 29, 2016

sarnex force-pushed the master branch from ff2271e to 513789f Compare May 1, 2016 23:21

sarnex force-pushed the master branch from 513789f to 47eca2c Compare May 3, 2016 22:11

sarnex changed the title ~~Update Linux support to 0.0.5~~ Update Linux support to 0.0.6 May 3, 2016

sarnex force-pushed the master branch 3 times, most recently from 890e9f5 to 03e5f06 Compare May 3, 2016 22:58

sarnex force-pushed the master branch from 03e5f06 to a762325 Compare May 4, 2016 23:10

sarnex changed the title ~~Update Linux support to 0.0.6~~ Update Linux support to 0.0.7 May 4, 2016

sarnex force-pushed the master branch 2 times, most recently from 1f82c32 to 18fb5c2 Compare May 4, 2016 23:17

sarnex force-pushed the master branch 2 times, most recently from 04ee627 to 79d00fd Compare May 8, 2016 01:29

sarnex force-pushed the master branch from 79d00fd to 5e7ec18 Compare May 8, 2016 01:35

sarnex changed the title ~~Update Linux support to 0.0.7~~ Update Linux support to 0.0.8 May 10, 2016

sarnex force-pushed the master branch from 50f753a to 4541bfd Compare January 11, 2017 17:33

sarnex force-pushed the master branch from 4541bfd to 32feebe Compare January 26, 2017 16:44

mkody and others added 4 commits January 29, 2017 15:37

Change linux path to use the $HOME/.config folder

c6f85e5

Update version of BD in config.json

ef10e07

Fix path to the bdStorage.json for case-sensitive partitions

f08539d

Update Linux support to 0.0.14

be22c14

Signed-off-by: Nick Sarnie <[email protected]>

sarnex force-pushed the master branch from 32feebe to be22c14 Compare January 29, 2017 17:28

Merge pull request #1 from mkody/fix-mainjs-linux

ddda646

Change linux path to use the $HOME/.config folder

noodlebox mentioned this pull request Feb 4, 2017

Fix Electron installer for OSX #439

Merged

noodlebox mentioned this pull request Feb 7, 2017

Fix case sensitive files #444

Closed

Jiiks merged commit 11190a8 into Jiiks:master Feb 10, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Linux support to 0.0.13 #288

Update Linux support to 0.0.13 #288

sarnex commented Apr 21, 2016 •

edited

Loading

brawaru Apr 21, 2016

sarnex Apr 21, 2016 •

edited

Loading

brawaru commented Apr 22, 2016 •

edited

Loading

Francesco149 commented Apr 22, 2016

mkody commented Apr 24, 2016

sarnex commented Apr 26, 2016 •

edited

Loading

brawaru commented May 3, 2016

sarnex commented May 3, 2016 •

edited

Loading

brawaru commented May 4, 2016

brawaru commented May 4, 2016

sarnex commented May 4, 2016 •

edited

Loading

mkody commented May 6, 2016

sarnex commented May 8, 2016

mkody commented May 10, 2016

brawaru commented May 14, 2016

mkody commented Jan 11, 2017 •

edited

Loading

simoniz0r commented Jan 11, 2017

sarnex commented Jan 11, 2017 via email •

edited

Loading

simoniz0r commented Jan 11, 2017

magiruuvelvet commented Jan 26, 2017

mkody commented Jan 26, 2017 •

edited

Loading

simoniz0r commented Jan 26, 2017

sarnex commented Jan 26, 2017 via email

magiruuvelvet commented Jan 27, 2017

dddlr commented Jan 27, 2017

Arzte commented Jan 30, 2017

simoniz0r commented Feb 4, 2017

sarnex commented Feb 4, 2017 via email

simoniz0r commented Feb 4, 2017 •

edited

Loading

sarnex commented Feb 4, 2017 via email

simoniz0r commented Feb 4, 2017

Jiiks commented Feb 10, 2017

mkody commented Feb 10, 2017 •

edited

Loading

sarnex commented Feb 10, 2017 via email

Update Linux support to 0.0.13 #288

Update Linux support to 0.0.13 #288

Conversation

sarnex commented Apr 21, 2016 • edited Loading

brawaru Apr 21, 2016

Choose a reason for hiding this comment

sarnex Apr 21, 2016 • edited Loading

Choose a reason for hiding this comment

brawaru commented Apr 22, 2016 • edited Loading

Francesco149 commented Apr 22, 2016

mkody commented Apr 24, 2016

sarnex commented Apr 26, 2016 • edited Loading

brawaru commented May 3, 2016

sarnex commented May 3, 2016 • edited Loading

brawaru commented May 4, 2016

brawaru commented May 4, 2016

sarnex commented May 4, 2016 • edited Loading

mkody commented May 6, 2016

sarnex commented May 8, 2016

mkody commented May 10, 2016

brawaru commented May 14, 2016

mkody commented Jan 11, 2017 • edited Loading

simoniz0r commented Jan 11, 2017

sarnex commented Jan 11, 2017 via email • edited Loading

simoniz0r commented Jan 11, 2017

magiruuvelvet commented Jan 26, 2017

mkody commented Jan 26, 2017 • edited Loading

simoniz0r commented Jan 26, 2017

sarnex commented Jan 26, 2017 via email

magiruuvelvet commented Jan 27, 2017

dddlr commented Jan 27, 2017

Arzte commented Jan 30, 2017

simoniz0r commented Feb 4, 2017

sarnex commented Feb 4, 2017 via email

simoniz0r commented Feb 4, 2017 • edited Loading

sarnex commented Feb 4, 2017 via email

simoniz0r commented Feb 4, 2017

Jiiks commented Feb 10, 2017

mkody commented Feb 10, 2017 • edited Loading

sarnex commented Feb 10, 2017 via email

sarnex commented Apr 21, 2016 •

edited

Loading

sarnex Apr 21, 2016 •

edited

Loading

brawaru commented Apr 22, 2016 •

edited

Loading

sarnex commented Apr 26, 2016 •

edited

Loading

sarnex commented May 3, 2016 •

edited

Loading

sarnex commented May 4, 2016 •

edited

Loading

mkody commented Jan 11, 2017 •

edited

Loading

sarnex commented Jan 11, 2017 via email •

edited

Loading

mkody commented Jan 26, 2017 •

edited

Loading

simoniz0r commented Feb 4, 2017 •

edited

Loading

mkody commented Feb 10, 2017 •

edited

Loading