Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed duplicates in MonolithicAwt and LiveMapMonolithicJfx #98

Merged
merged 6 commits into from
Mar 31, 2020
Merged

Fixed duplicates in MonolithicAwt and LiveMapMonolithicJfx #98

merged 6 commits into from
Mar 31, 2020

Conversation

ISeleznev-HORIS
Copy link
Collaborator

No description provided.

@alshan
Copy link
Collaborator

alshan commented Mar 19, 2020

Let's do not create a hierarchy of monolithics. I would like to see MonolithicAwt as object with couple static methods (as before). The same applies to LiveMapMonolithic.

I can propose to extract the common code to another class or object (don't name it Monolithic please) to which LiveMap/Awt monolithics will delegate their job without inheritance.

@alshan alshan merged commit 1e0e2a0 into master Mar 31, 2020
@alshan alshan deleted the monolithic-duplicates branch March 31, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alshan alshan alshan requested changes

@IKupriyanov-HORIS IKupriyanov-HORIS Awaiting requested review from IKupriyanov-HORIS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ISeleznev-HORIS @alshan