Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code in AesOptionConversion #924

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Improve code in AesOptionConversion #924

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47e6f56
Remove `fun has(aes)`
OLarionova-HORIS Nov 8, 2023
effc67f
Cleanup `applyToList()`.
OLarionova-HORIS Nov 8, 2023
6de2797
Use `assertDoesNotFail()` in test.
OLarionova-HORIS Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use assertDoesNotFail() in test.
  • Loading branch information
@OLarionova-HORIS
OLarionova-HORIS committed Nov 8, 2023
commit 6de27979fb5abc97a3f27d6905f0c5dd1b15905e
6 changes: 2 additions & 4 deletions ...vmTest/kotlin/org/jetbrains/letsPlot/core/spec/back/conversion/AesOptionConversionTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,17 @@

package org.jetbrains.letsPlot.core.spec.config.conversion

import demoAndTestShared.assertDoesNotFail
import org.jetbrains.letsPlot.core.plot.base.Aes
import org.jetbrains.letsPlot.core.spec.conversion.AesOptionConversion
import kotlin.test.Test
import kotlin.test.fail

class AesOptionConversionTest {
@Test
fun everyAesHasOptionValueConverter() {
for (aes in Aes.values()) {
try {
assertDoesNotFail("Aes '${aes.name}' has no option value converter. ") {
AesOptionConversion.demoAndTest.getConverter(aes)
} catch (e: Throwable) {
fail("Aes '${aes.name}' has no option value converter")
}
}
}
Expand Down