Fixes in docstrings #841
Merged
Fixes in docstrings #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alshan
requested changes
Aug 8, 2023
python-package/lets_plot/__init__.py
Outdated
| @@ -142,6 +142,18 @@ def set(cls, settings: Dict): | |||
|
|
|||
There was a problem hiding this comment.
Earlier in the docstring:
Geocoding settings could also be specified: ...
This is not "Geocoding settings".
Lets call it "Interactive map settings".
python-package/lets_plot/__init__.py
Outdated
| @@ -142,6 +142,18 @@ def set(cls, settings: Dict): | |||
|
|
|||
| | | |||
|
|
|||
There was a problem hiding this comment.
Also in this docstring:
LetsPlot.set(maptiles_lets_plot(theme='light'))
Doesn't seem correct, take a look at this notebook: https://datalore.jetbrains.com/report/static/HZqq77cegYd.E7get_WnChZ/05NSsbcsOYZMBN9n4JfKzL
We now are using constants like: tilesets.LETS_PLOT_LIGHT
We also need to add here a reference on our docpage: https://lets-plot.org/pages/basemap_tiles.html#basemap-tiles
python-package/lets_plot/__init__.py
Outdated
| @@ -150,12 +162,12 @@ def set(cls, settings: Dict): | |||
| LetsPlot.setup_html() | |||
| attribution = ''' | |||
There was a problem hiding this comment.
Pls, replace this example with more common and simple LetsPlot.set(tilesets.STAMEN_DESIGN_TERRAIN).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
size_unit