Move scaling of the Y axis inside the step geometry.

plot-base/src/commonMain/kotlin/org/jetbrains/letsPlot/core/plot/base/geom/StepGeom.kt

@@ -6,6 +6,7 @@
 package org.jetbrains.letsPlot.core.plot.base.geom
 
 import org.jetbrains.letsPlot.commons.geometry.DoubleVector
+import org.jetbrains.letsPlot.commons.interval.DoubleSpan
 import org.jetbrains.letsPlot.core.plot.base.*
 import org.jetbrains.letsPlot.core.plot.base.geom.util.GeomHelper
 import org.jetbrains.letsPlot.core.plot.base.geom.util.GeomUtil
@@ -14,7 +15,7 @@ import org.jetbrains.letsPlot.core.plot.base.geom.util.TargetCollectorHelper
 import org.jetbrains.letsPlot.core.plot.base.render.SvgRoot
 import org.jetbrains.letsPlot.datamodel.svg.dom.SvgLineElement
 
-class StepGeom : LineGeom() {
+class StepGeom : LineGeom(), WithHeight {
  private var myDirection = DEF_DIRECTION
  var padded = DEF_PADDED
 
@@ -100,6 +101,19 @@ class StepGeom : LineGeom() {
  return pads
  }
 
+ override fun heightSpan(
+ p: DataPointAesthetics,
+ coordAes: Aes<Double>,
+ resolution: Double,
+ isDiscrete: Boolean
+ ): DoubleSpan? {
+ return when {
+ padded -> DoubleSpan(0.0, 1.0)
+ p.x()?.isFinite() == true && p.y()?.isFinite() == true -> DoubleSpan(p.y()!!, p.y()!!)
+ else -> DoubleSpan(-0.5, 0.5)
+ }
+ }
+
  enum class Direction {
  HV, VH;
 

python-package/lets_plot/plot/stat.py

@@ -1,7 +1,6 @@
 # Copyright (c) 2023. JetBrains s.r.o.
 # Use of this source code is governed by the MIT license that can be found in the LICENSE file.
 from .geom import _geom
-from .scale_convenience import xlim, ylim
 
 #
 # Stats - functions, drawing attention to the statistical transformation rather than the visual appearance.
@@ -463,10 +462,6 @@ def stat_ecdf(mapping=None, *, data=None, geom=None,
  """
  ecdf_geom = geom if geom is not None else 'step'
  ecdf_pad = pad if pad is not None else True
- if orientation == 'y':
- limits_spec = xlim(0, 1)
- else:
- limits_spec = ylim(0, 1)
  return _geom(ecdf_geom,
  mapping=mapping,
  data=data,
@@ -479,5 +474,4 @@ def stat_ecdf(mapping=None, *, data=None, geom=None,
  n=n,
  pad=ecdf_pad,
  color_by=color_by,
- **other_args) + \
- limits_spec
+ **other_args)