Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geom_pie(): new parameters for stroke and spacers #823

Merged
merged 20 commits into from
Jul 20, 2023
Merged

geom_pie(): new parameters for stroke and spacers #823

merged 20 commits into from
Jul 20, 2023

Conversation

OLarionova-HORIS
Copy link
Contributor

  • stroke, color for pie arcs
  • stroke_side - which arcs should have a stroke
  • spacer_width, spacer_color - lines between sectors

@OLarionova-HORIS
geom_pie(): stroke to arcs, new parameters for borders between slices.
3e5a3ec
@OLarionova-HORIS
Rename parameters, remove stroke_side='none'.
6ced0e0
@OLarionova-HORIS
Use plot background for 'spacer_color' by default.
b0b120b
@OLarionova-HORIS
Fix drawing: add arcs if stroke width > 0, not draw spacer lines for …
f696e6e 
…exploded sectors.
@OLarionova-HORIS
Add hole (with size of stroke) if 'stoke_side' specifies inner stroke.
9337546
@OLarionova-HORIS
Add new example.
28b28a2
@OLarionova-HORIS
Access to plot background via GeomContext.
922df2b
@OLarionova-HORIS
Fix after merge.
7b951df
@OLarionova-HORIS
Change defaults for stroke side and spacer width.
c96f627
@OLarionova-HORIS
Add a hole if an inner stroke is needed: increase the size by spacer …
563a7b3 
…width.
@OLarionova-HORIS
Not draw spacer lines for exploded sectors and their neighbors
c4cab0e
@OLarionova-HORIS
Remove extra import.
ee8fb4a
@OLarionova-HORIS
Code cleanup, move 'stroke_side' from PieGeom to GeomProvider.
5a1dce1
@OLarionova-HORIS
Refactoring.
30d24c5
@OLarionova-HORIS
Add new parameters with descriptions to geom_pie().
c95734a
@OLarionova-HORIS
Update docstrings: add new example.
ff4f270
@OLarionova-HORIS
Minor cleanup.
8fd9f17
@OLarionova-HORIS
Code cleanup.
0fa1c64
@OLarionova-HORIS
Minor cleanups (fix text of error message, descriptions in docstrings…
1eb82ab 
…, pie demos).
@OLarionova-HORIS
Add notebook and update future_changes.md.
1b08aa5
@alshan alshan merged commit 11b2ea0 into master Jul 20, 2023
@OLarionova-HORIS OLarionova-HORIS deleted the pie-slice-borders branch July 27, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OLarionova-HORIS @alshan