Make line width equal to point's stroke width #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pointrange and lollipop.
alshan
requested changes
Jun 22, 2023
...table/src/commonMain/kotlin/jetbrains/datalore/plot/builder/defaultTheme/DefaultGeomTheme.kt
Outdated
Show resolved
Hide resolved
plot-base-portable/src/commonMain/kotlin/jetbrains/datalore/plot/base/aes/AestheticsUtil.kt
Show resolved
Hide resolved
| GeomKind.Q_Q, | ||
| GeomKind.Q_Q_2 -> { | ||
| color = inheritedColors.lineColor() | ||
| fill = Colors.withOpacity(inheritedColors.lineColor(), 0.1) |
There was a problem hiding this comment.
We don't want to use colors with opacity.
There was a problem hiding this comment.
Changed to fill = background color
| GeomKind.LOLLIPOP -> { | ||
| color = inheritedColors.lineColor() | ||
| fill = Colors.withOpacity(inheritedColors.lineColor(), 0.1) | ||
| size = 2.0 | ||
| lineWidth = 1.0 // line width and stroke for point | ||
| } | ||
|
|
||
| GeomKind.SMOOTH -> { |
There was a problem hiding this comment.
This is bad: alpha = 1.5
GeomKind.SMOOTH -> {
color = Color.MAGENTA
We don't want to use constant values no longer. Should be a field in BASE (but still get rid of the BASE).
alshan
requested changes
Jun 26, 2023
| @@ -105,28 +106,40 @@ internal class DefaultGeomTheme private constructor( | |||
| color = inheritedColors.lineColor() | |||
| fill = inheritedColors.lineColor() | |||
| alpha = 0.1 | |||
| size = 0.2 | |||
| size = 0.24 | |||
There was a problem hiding this comment.
Extract the experimental multiplier (1.2) to a val .
Make line widths thicker. Update notebooks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… pointrange and lollipop.