Updates in lollipops #768

ASmirnov-HORIS · 2023-04-25T14:58:21Z

…metry.

… is lollipop.

alshan · 2023-04-25T17:50:05Z

plot-builder-portable/src/commonMain/kotlin/jetbrains/datalore/plot/builder/PlotUtil.kt

@@ -168,12 +168,16 @@ object PlotUtil {
 internal fun rangeWithExpand(


Could you instead keep the size related stuff in lollipop geom widthSpan / heightSpan ?

ASmirnov-HORIS added 7 commits April 24, 2023 15:43

Add conditional including of zero to the Y-range for the lollipop geo…

351997c

…metry.

Increase multiplicative expand for the continuous scale when geometry…

47294a8

… is lollipop.

Update the cookbook-notebook for the lollipop geometry.

961d56b

Refactor continuous scale expanding for the lollipop geometry.

b8f4b9d

Refactor scale expand parameters for the lollipop geometry.

68d251f

Fix rangeIncludesZero() for lollipops.

b0bf374

Rerun cookbook-notebook for the lollipop geometry.

c449f99

alshan requested changes Apr 25, 2023

View reviewed changes

ASmirnov-HORIS added 5 commits April 27, 2023 13:35

Change behaviour of the dir parameter for the lollipop geometry.

9824de6

Undo expanding scales for lollipops.

163d7bf

Update API for geom_lollipop() (change behaviour of the dir parameter).

ce2bcd2

Fix the future_changes.md file.

74d26eb

Rebuild the cookbook-notebook for the lollipop geometry.

b308b7b

ASmirnov-HORIS changed the title ~~Fix scales for lollipops~~ Updates in lollipops Apr 28, 2023

ASmirnov-HORIS requested a review from alshan April 28, 2023 15:40

alshan merged commit a29e35e into master Apr 28, 2023

ASmirnov-HORIS deleted the lollipop branch May 2, 2023 10:12

Provide feedback

		@@ -168,12 +168,16 @@ object PlotUtil {
		internal fun rangeWithExpand(