Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding of Swing component painting behavior #722

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

ileasile
Copy link
Member

I want to prevent rendering of Swing lets-plots over other components in IDEA, that's why I need IDEA-specific override for paint() method. I've used SPI to achieve this as such a change seems to be less painful than something else

Copy link
Collaborator

@alshan alshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does seem you don't need to provide the entire BatikMapperComponentHelper via SPI.
Perhaps, all you need is somethis like

interface BatikGraphicsNodeRenderer {
  fun paint(node: GraphicsNode, g: Graphics2D)
}

Make sence?

@ileasile
Copy link
Member Author

Actually yes, I need to override this exact interface on IDEA side, but I also need to propagate this object to the lets-plot machinery

@ileasile
Copy link
Member Author

Or do you mean to keep using SPI, but for another interface? This makes sense, yes

@alshan alshan merged commit d0fb3f6 into master Mar 21, 2023
@IKupriyanov-HORIS IKupriyanov-HORIS deleted the allow-swing-paint-override branch September 27, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants