Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev branch #66

Merged
merged 15 commits into from
Dec 18, 2019
Merged

dev branch #66

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
2084319
base <=> base-portable refactoring
IKupriyanov-HORIS Dec 13, 2019
807f441
Added location systems.
ISeleznev-HORIS Dec 9, 2019
9f7baed
Added StartMapLocationSystem.
ISeleznev-HORIS Dec 16, 2019
92313ad
After merge
ISeleznev-HORIS Dec 16, 2019
1c13da0
rename
IKupriyanov-HORIS Dec 16, 2019
7713289
String.escape() for JSON
IKupriyanov-HORIS Dec 10, 2019
e60da93
Fixed map piechart start angle.
ISeleznev-HORIS Dec 16, 2019
ec2c792
Fixed using isGeodesic for rect and polygons.
ISeleznev-HORIS Dec 17, 2019
86629c7
Added throwing error on geocoding failure.
ISeleznev-HORIS Dec 18, 2019
f1e711f
Fixed calculation of location for path and polygons .
ISeleznev-HORIS Dec 18, 2019
ac23b8e
Fixed blur on vector tiles.
ISeleznev-HORIS Dec 18, 2019
5b7295d
Fixed drawing point in MakeGeometryWidgetSystem.
ISeleznev-HORIS Dec 18, 2019
5dffa1e
Move GeoJson support into base
IKupriyanov-HORIS Dec 18, 2019
c0ec863
Restore -lstdc++ for setup.py
IKupriyanov-HORIS Dec 18, 2019
7754db0
Minor fixes
IKupriyanov-HORIS Dec 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added throwing error on geocoding failure.
  • Loading branch information
@ISeleznev-HORIS @IKupriyanov-HORIS
ISeleznev-HORIS authored and IKupriyanov-HORIS committed Dec 18, 2019
commit 86629c7e69024b91fb56b7276efa4aee8d0bf567
3 changes: 2 additions & 1 deletion livemap/src/commonMain/kotlin/jetbrains/livemap/LiveMap.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ class LiveMap(
myContext = LiveMapContext(
myMapProjection,
canvasControl,
MapRenderContext(viewport, canvasControl)
MapRenderContext(viewport, canvasControl),
::fireThrowable
)

myUiService = UiService(componentManager, ResourceManager(myContext.mapRenderContext.canvasProvider))
Expand Down
3 changes: 2 additions & 1 deletion livemap/src/commonMain/kotlin/jetbrains/livemap/LiveMapContext.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,6 @@ import jetbrains.livemap.projections.MapProjection
open class LiveMapContext(
open val mapProjection: MapProjection,
eventSource: MouseEventSource,
open val mapRenderContext: MapRenderContext
open val mapRenderContext: MapRenderContext,
val showError: (Throwable) -> Unit
) : EcsContext(eventSource)
11 changes: 7 additions & 4 deletions ...map/src/commonMain/kotlin/jetbrains/livemap/entities/geocoding/RegionIdGeocodingSystem.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,14 @@ class RegionIdGeocodingSystem(
requested.forEach { it.add(WaitingGeocodingComponent()) }

myGeocodingProvider.geocodeRegions(names)
.map { regionIdByNames ->
getMutableEntities(GEOCODED_FEATURE_COMPONENTS).forEach { entity ->
entity.add(RegionIdComponent(regionIdByNames.getValue(entity.get<MapIdComponent>().mapId)))
entity.remove<MapIdComponent>()
.apply {
onSuccess { regionIdByNames ->
getMutableEntities(GEOCODED_FEATURE_COMPONENTS).forEach { entity ->
entity.add(RegionIdComponent(regionIdByNames.getValue(entity.get<MapIdComponent>().mapId)))
entity.remove<MapIdComponent>()
}
}
onFailure { context.showError(it) }
}
}

Expand Down