Violin geometry #487
Merged
Violin geometry #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scale='width' version of statistic computation is realized by default.
alshan
requested changes
Dec 15, 2021
plot-base-portable/src/commonMain/kotlin/jetbrains/datalore/plot/base/GeomMeta.kt
Outdated
Show resolved
Hide resolved
plot-base-portable/src/commonMain/kotlin/jetbrains/datalore/plot/base/stat/ViolinStat.kt
Outdated
Show resolved
Hide resolved
plot-base-portable/src/commonMain/kotlin/jetbrains/datalore/plot/base/geom/ViolinGeom.kt
Outdated
Show resolved
Hide resolved
plot-base-portable/src/commonMain/kotlin/jetbrains/datalore/plot/base/geom/ViolinGeom.kt
Outdated
Show resolved
Hide resolved
| bwMethod: DensityStat.BandWidthMethod, | ||
| ad: Double, | ||
| ker: DensityStat.Kernel, | ||
| fullScalMax: Int |
There was a problem hiding this comment.
copy-paste failure :) Pls. rename to fullScanMax.
...ilder-portable/src/commonMain/kotlin/jetbrains/datalore/plot/builder/scale/DefaultNaValue.kt
Outdated
Show resolved
Hide resolved
plot-base-portable/src/commonMain/kotlin/jetbrains/datalore/plot/base/stat/ViolinStat.kt
Outdated
Show resolved
Hide resolved
plot-base-portable/src/commonMain/kotlin/jetbrains/datalore/plot/base/stat/ViolinStat.kt
Outdated
Show resolved
Hide resolved
plot-config-portable/src/commonMain/kotlin/jetbrains/datalore/plot/config/GeomProto.kt
Outdated
Show resolved
Hide resolved
plot-config-portable/src/commonMain/kotlin/jetbrains/datalore/plot/config/StatKind.kt
Outdated
Show resolved
Hide resolved
alshan
requested changes
Dec 16, 2021
| @@ -67,6 +68,7 @@ object AesInitValue { | |||
| VALUE_MAP[SIZE] = 0.5 // Line thickness. Should be redefined for other shapes | |||
| VALUE_MAP[WIDTH] = 1.0 | |||
| VALUE_MAP[HEIGHT] = 1.0 | |||
| VALUE_MAP[VIOLINWIDTH] = 1.0 | |||
There was a problem hiding this comment.
0.0 would make more sense, though violinwidth default is hardly eve used.
|
|
||
| private fun toLocationBound(sign: Double, ctx: GeomContext): (p: DataPointAesthetics) -> DoubleVector? { | ||
| return fun (p: DataPointAesthetics): DoubleVector? { | ||
| val x = p.x()!! + ctx.getResolution(Aes.X) / 2 * DEF_WIDTH * sign * p.violinwidth()!! |
There was a problem hiding this comment.
"DEF_WIDTH" is not a good name. This is rather some scaling which makes violin plot look better.
| xs | ||
| val densityFunction = DensityStatUtil.densityFunction( | ||
| xs, weights, | ||
| bandWidth, bandWidthMethod, adjust, kernel, fullScalMax |
There was a problem hiding this comment.
Rename: fullScalMax -> fullScanMax
|
|
||
| override fun normalize(data: DataFrame): DataFrame { | ||
| val statDensity = data.getNumeric(Stats.DENSITY).map { it!! } | ||
| val densityMax = statDensity.maxOrNull()!! |
There was a problem hiding this comment.
NPE in case of an empty dataframe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.