Specs cleanup #477
Merged
Specs cleanup #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alshan
requested changes
Nov 24, 2021
| return obj | ||
|
|
||
|
|
||
| def _cleanup_spec(obj: dict): |
There was a problem hiding this comment.
Looks tricky, has too much knowledge about internals, trying to do too much when this is not required.
Lets's use _filter_none (move it to core, may be rename) in _specs_to_dict(opts_raw) when v is a dict.
…pty dicts for corr_plot layers, skip cleanup for 'data' dicts.
IKupriyanov-HORIS
force-pushed
the
to-dict-cleanup
branch
from
3a4ea6f
to
7e3cb2b
Compare
alshan
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.