Move vis-svg-mapper-batik dependency on test-common to commonTest source set #455
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently vis-svg-mapper-batik has a commonMain dependency on the test-common project. When creating the shadow jar for JVM batik, this results in the jar having a service provider for
kotlin.test.AsserterContributor
withkotlin.test.junit.JUnitContributor
. This results in errors when using the library in a project that uses a different kotlin-test implementation (such as JUnit 5).In my case, the following error results:
java.util.ServiceConfigurationError: kotlin.test.AsserterContributor: Provider kotlin.test.junit.JUnitContributor not found
.This patch moves the dependency to the commonTest source set, ultimately removing the service provider from the shadow jar.