Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateTime format support in tooltips #421

Merged
merged 8 commits into from
Aug 18, 2021
Merged

DateTime format support in tooltips #421

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bd1d0b8
Add support of DateTime format to StringFormat.
OLarionova-HORIS Jun 23, 2021
32ff468
Add test: use DateTime format in tooltip format().
OLarionova-HORIS Jun 23, 2021
cf0900b
Rename Format -> DateTimeFormat.
OLarionova-HORIS Jul 2, 2021
f04180f
Minor code cleanup.
OLarionova-HORIS Jul 2, 2021
b853796
Minor code cleanup.
OLarionova-HORIS Aug 10, 2021
618c3a4
Code cleanup: add function parseOrNull to create NumberFormat.
OLarionova-HORIS Aug 11, 2021
b6ba61f
Minor changes: new error messages, add function isDateTimeFormat.
OLarionova-HORIS Aug 17, 2021
ada9bb4
Add notebook with examples of date-time formatting.
OLarionova-HORIS Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor code cleanup.
  • Loading branch information
@OLarionova-HORIS
OLarionova-HORIS committed Aug 16, 2021
commit f04180f83d149e1cbcd891b868eaddcbcad464da
10 changes: 5 additions & 5 deletions base-portable/src/commonMain/kotlin/jetbrains/datalore/base/stringFormat/StringFormat.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ class StringFormat private constructor(
) {
enum class FormatType {
NUMBER_FORMAT,
STRING_FORMAT,
DATETIME_FORMAT
DATETIME_FORMAT,
STRING_FORMAT
}

private val myFormatters: List<((Any) -> String)?>
private val myFormatters: List<((Any) -> String)>

init {
myFormatters = when (formatType) {
Expand Down Expand Up @@ -67,9 +67,9 @@ class StringFormat private constructor(
}
}

private fun initFormatter(formatPattern: String, formatType: FormatType): ((Any) -> String)? {
private fun initFormatter(formatPattern: String, formatType: FormatType): ((Any) -> String) {
if (formatPattern.isEmpty()) {
return null
return Any::toString
}
when (formatType) {
NUMBER_FORMAT -> {
Expand Down