Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reordering #411

Merged
merged 11 commits into from
Jul 29, 2021
Merged

Reordering #411

merged 11 commits into from
Jul 29, 2021

Commits on Jul 27, 2021

  1. - When ordering by the variable which has same values, need also chec… 

    …k own values. Add test.

- Add new tests: check ordering in data, data with null values.
    @OLarionova-HORIS
    OLarionova-HORIS committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    a971e7d View commit details
    Browse the repository at this point in the history

  2. Add merging of groups after stat applying according to ordering setti… 

    …ngs.
    @OLarionova-HORIS
    OLarionova-HORIS committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    472513a View commit details
    Browse the repository at this point in the history

  3. Minor code improvement.

    @OLarionova-HORIS
    OLarionova-HORIS committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    a367498 View commit details
    Browse the repository at this point in the history

  4. Add checking of order direction: require -1 or 1. 

    Fix comparator for groups. Add new tests.
    @OLarionova-HORIS
    OLarionova-HORIS committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    73c7001 View commit details
    Browse the repository at this point in the history

  5. Add order settings from discrete to non-discrete mappings. 

    Fix test.
    @OLarionova-HORIS
    OLarionova-HORIS committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    cb33310 View commit details
    Browse the repository at this point in the history

  6. Code cleanup.

    @OLarionova-HORIS
    OLarionova-HORIS committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    68e1ded View commit details
    Browse the repository at this point in the history

  7. Apply order options from layer's discrete variable to plot's non-disc… 

    …rete variable and vice versa.

Add test.
Update notebook.
    @OLarionova-HORIS
    OLarionova-HORIS committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    0f284d8 View commit details
    Browse the repository at this point in the history

  8. Update the data in tests (it will improve examples with 'count'). 

    Add new examples in the notebook.
    @OLarionova-HORIS
    OLarionova-HORIS committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    6bed216 View commit details
    Browse the repository at this point in the history

  9. Add 'sum' as aggregate operation for position='stack'.

    @OLarionova-HORIS
    OLarionova-HORIS committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    0e30f7e View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2021

  1. Update notebook: add sampling_pick + order_by='..count..'.

    @OLarionova-HORIS
    OLarionova-HORIS committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    7f85525 View commit details
    Browse the repository at this point in the history

  2. Make class GroupMerger as a top-level internal class.

    @OLarionova-HORIS
    OLarionova-HORIS committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    16dbab0 View commit details
    Browse the repository at this point in the history