Corr plot module #220
Merged
Corr plot module #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alshan
requested changes
Nov 9, 2020
| This class is intended to build correlation matrix plots. | ||
| """ | ||
|
|
||
| def __init__(self, data, show_legend=None, flip=None): |
| self._data = data | ||
| self._show_legend = show_legend | ||
| self._format = '.2f' | ||
| self._reverse_y = flip if flip is not None else True |
There was a problem hiding this comment.
True if flip else False
would work.
| if color: | ||
| other_args['color'] = color | ||
| else: | ||
| other_args['color'] = self._text_color |
There was a problem hiding this comment.
What happens with text's color if user adds 'tiles' after 'labels'?
|
|
||
| return res | ||
|
|
||
| def _set_diverging_palette(self, palette): |
There was a problem hiding this comment.
Let's rename to _set_brewer_palette.
|
|
||
| def _set_diverging_palette(self, palette): | ||
| self._color_scale = scale_color_brewer(name='Correlation', | ||
| type='div', |
|
|
||
| layers = [] | ||
|
|
||
| if self._tiles_layer: |
There was a problem hiding this comment.
Let's use API:
plot = ggplot(self._data)
if self._tiles_layer:
plot += self._tiles_layer
...
alshan
requested changes
Nov 10, 2020
| self._text_color = None | ||
| self._tiles_layer = None | ||
| self._points_layer = None | ||
| self._labels_layer = None | ||
| self._color_scale = scale_color_gradient2(name='Correlation', |
There was a problem hiding this comment.
'Correlation' takes too much space on the plot, let's call it 'Corr'.
IKrukov-HORIS
force-pushed
the
corr_plot_module
branch
4 times, most recently
from
9149e2f
to
ebdac2d
Compare
IKrukov-HORIS
force-pushed
the
corr_plot_module
branch
from
b14c4d0
to
0116ad0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.