Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autorotate discrete #1032

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Autorotate discrete #1032

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9acb86b
Refactoring of choosing orientation. Move logic into init method of L…
RYangazov Mar 29, 2024
1871f19
Refactor isAesDiscrete. Add unit-tests.
RYangazov Apr 1, 2024
67bb1fa
Disable automatic orientation selection if it is specified by the user.
RYangazov Apr 4, 2024
2b23c4e
Move initialization of isYOrientation variable.
RYangazov Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disable automatic orientation selection if it is specified by the user.
  • Loading branch information
@RYangazov
RYangazov committed Apr 8, 2024
commit 67bb1fad67d78e79c173c27372e908256bbd3ba8
888 changes: 888 additions & 0 deletions docs/dev/notebooks/auto_orientation_discretes_with_user_input.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions plot-stem/src/commonMain/kotlin/org/jetbrains/letsPlot/core/spec/config/LayerConfig.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ class LayerConfig(
)

if (!clientSide
alshan marked this conversation as resolved.
Show resolved Hide resolved
&& !hasOwn(ORIENTATION)
&& isOrientationApplicable()
&& !DataConfigUtil.isAesDiscrete(
Aes.X,
Expand Down