Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_discrete: a rounding error. #135

Closed
alshan opened this issue May 8, 2020 · 2 comments
Closed

is_discrete: a rounding error. #135

alshan opened this issue May 8, 2020 · 2 comments
Milestone
1.4.2

Comments

@alshan
Copy link
Collaborator

alshan commented May 8, 2020

See geom_smooth.ipynb

A rounding error occurs when using 'is_discrete'. However, its not clear whether this is caused by 'is_discrete' or not.

image
alshan added a commit that referenced this issue May 9, 2020
@alshan
Patch DataProcessing.kt to fix "is_discrete: a rounding error. #135",…
e7c5ca7 
… update geom_smooth.ipynb demo.
@alshan
Copy link
Collaborator Author

alshan commented May 9, 2020

I've patched DataProcessing (e7c5ca7).

Needs further investigation:

  • Why data.isNumeric(variable) returns True. Expected False for as_discrete(var)
  • It seems that two different color scales are created for points layer and for lines layer. Expected - one color scale per plot.

@IKupriyanov-HORIS IKupriyanov-HORIS added this to the 1.4.1 milestone May 15, 2020
IKupriyanov-HORIS added a commit that referenced this issue May 22, 2020
@IKupriyanov-HORIS
Fix #135 rounding error. No fix for color.
eab0756
@IKupriyanov-HORIS
Copy link
Collaborator

Fixed rounding error, but color scales issue is not related with as_discrete function and requires separate issue:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.2
Development

No branches or pull requests
2 participants
@alshan @IKupriyanov-HORIS