Skip to content

Commit

Permalink
Update Kotlin to 1.9.20, Gradle to 8.4 (#925)
Browse files Browse the repository at this point in the history
* Update Gradle to 8.4, Kotlin to 1.9.20. Resolve conflicts and errors.

* Fix JS path for demo

* Remove BarsDemoBrowser.kt
  • Loading branch information
VDovidaytis-HORIS committed Nov 8, 2023
1 parent d708fd9 commit 0e6fc3e
Show file tree
Hide file tree
Showing 8 changed files with 46 additions and 28 deletions.
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ nexusPublishing {
// "JavaDoc" artifact for all publications.
task jarJavaDocs(type: Jar) {
group project.letsPlotTaskGroup
classifier 'javadoc'
archiveClassifier.set("javadoc")
from("$rootDir/README.md")
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ object BrowserDemoUtil {
}

private fun projectJs(projectPath: String, projectName: String) =
"${getRootPath()}/$projectPath/build/distributions/$projectName.js"
"${getRootPath()}/$projectPath/build/dist/js/productionExecutable/$projectName.js"

fun mapperDemoHtml(demoProjectPath: String, demoProject: String, callFun: String, title: String): String {
return mapperDemoHtml(demoProjectPath, demoProject, callFun, null, title)
Expand Down
25 changes: 20 additions & 5 deletions demo/livemap/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,27 @@ plugins {
id "org.jetbrains.kotlin.multiplatform"
}

// KT-55751. MPP / Gradle: Consumable configurations must have unique attributes.
// https://youtrack.jetbrains.com/issue/KT-55751/MPP-Gradle-Consumable-configurations-must-have-unique-attributes
//
def dummyAttribute = Attribute.of("dummyAttribute", String)

kotlin {
jvm("jvmJfx")
jvm("jvmRawJfx")
jvm("jvmRawAwt")
jvm("jvmBrowser")
jvm("jvmJfxPlot")
jvm("jvmJfx") {
attributes.attribute(dummyAttribute, "jvmJfx")
}
jvm("jvmRawJfx") {
attributes.attribute(dummyAttribute, "jvmRawJfx")
}
jvm("jvmRawAwt") {
attributes.attribute(dummyAttribute, "jvmRawAwt")
}
jvm("jvmBrowser") {
attributes.attribute(dummyAttribute, "jvmBrowser")
}
jvm("jvmJfxPlot") {
attributes.attribute(dummyAttribute, "jvmJfxPlot")
}
jvm("jvmBatikPlot")
js {
browser()
Expand Down

This file was deleted.

13 changes: 11 additions & 2 deletions demo/plot/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,19 @@ plugins {
* Use of this source code is governed by the MIT license that can be found in the LICENSE file.
*/

// KT-55751. MPP / Gradle: Consumable configurations must have unique attributes.
// https://youtrack.jetbrains.com/issue/KT-55751/MPP-Gradle-Consumable-configurations-must-have-unique-attributes
//
def dummyAttribute = Attribute.of("dummyAttribute", String)

kotlin {
jvm("jvmBatik")
jvm("jvmJfx")
jvm("jvmBrowser")
jvm("jvmJfx") {
attributes.attribute(dummyAttribute, "jvmJfx")
}
jvm("jvmBrowser") {
attributes.attribute(dummyAttribute, "jvmBrowser")
}
js() {
browser()
binaries.executable()
Expand Down
13 changes: 11 additions & 2 deletions demo/svg/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,19 @@ plugins {
id "org.jetbrains.kotlin.multiplatform"
}

// KT-55751. MPP / Gradle: Consumable configurations must have unique attributes.
// https://youtrack.jetbrains.com/issue/KT-55751/MPP-Gradle-Consumable-configurations-must-have-unique-attributes
//
def dummyAttribute = Attribute.of("dummyAttribute", String)

kotlin {
jvm("jvmBatik")
jvm("jvmJfx")
jvm("jvmBrowser") // generates index.html and opens it in browser
jvm("jvmJfx") {
attributes.attribute(dummyAttribute, "jvmJfx")
}
jvm("jvmBrowser") { // generates index.html and opens it in browser
attributes.attribute(dummyAttribute, "jvmBrowser")
}
js() {
browser()
binaries.executable()
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
kotlin.code.style=official


kotlin_version=1.9.10
kotlin_version=1.9.20
kotlinLogging_version=2.0.5

kotlinx_html_version=0.7.3
Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\:https://services.gradle.org/distributions/gradle-7.6.2-bin.zip
distributionUrl=https\:https://services.gradle.org/distributions/gradle-8.4-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists

0 comments on commit 0e6fc3e

Please sign in to comment.