Use value classes for inline markdown #329 #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44e6ed1
to
c04758d
Compare
c04758d
to
0ddbe37
Compare
|
I thought that it makes scrolling errors more prominent, but it looks exactly the same as before... not sure if the bug is in CfD or the way we represent lists or remember some nodes... which is probably not the case, because these nodes don't change during rendering at all. |
0ddbe37
to
1bc717b
Compare
|
You need to run the |
rock3r
reviewed
Mar 27, 2024
markdown/core/src/main/kotlin/org/jetbrains/jewel/markdown/processing/MarkdownProcessor.kt
Outdated
Show resolved
Hide resolved
markdown/core/src/main/kotlin/org/jetbrains/jewel/markdown/processing/MarkdownProcessor.kt
Outdated
Show resolved
Hide resolved
markdown/core/src/main/kotlin/org/jetbrains/jewel/markdown/processing/MarkdownProcessor.kt
Outdated
Show resolved
Hide resolved
...core/src/main/kotlin/org/jetbrains/jewel/markdown/rendering/DefaultInlineMarkdownRenderer.kt
Show resolved
Hide resolved
.../core/src/main/kotlin/org/jetbrains/jewel/markdown/rendering/DefaultMarkdownBlockRenderer.kt
Outdated
Show resolved
Hide resolved
.../core/src/main/kotlin/org/jetbrains/jewel/markdown/rendering/DefaultMarkdownBlockRenderer.kt
Outdated
Show resolved
Hide resolved
...re/src/test/kotlin/org/jetbrains/jewel/markdown/MarkdownProcessorDocumentParsingExtraTest.kt
Outdated
Show resolved
Hide resolved
...wn/core/src/test/kotlin/org/jetbrains/jewel/markdown/MarkdownProcessorDocumentParsingTest.kt
Outdated
Show resolved
Hide resolved
...wn/core/src/test/kotlin/org/jetbrains/jewel/markdown/MarkdownProcessorDocumentParsingTest.kt
Outdated
Show resolved
Hide resolved
rock3r
requested changes
Mar 27, 2024
e066d06
to
6bb20ee
Compare
rock3r
approved these changes
Mar 31, 2024
This classes wrap CommonMark's nodes and preserve a familiar API. Some tests were turned off because we don't use the same IR for string serialization. Changing dataclasses to values classes for blocks is coming in the next pull request.
6bb20ee
to
35186c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This classes wrap CommonMark's nodes and preserve
a familiar API. Some tests were turned off because we don't use the same IR for string serialization.
Changing dataclasses to values classes for blocks
is coming in the next pull request.