Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade puppeteer from 20.7.3 to 21.5.0 #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jerk400
Copy link
Owner

@Jerk400 Jerk400 commented Feb 15, 2024

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json
    • package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 823/1000
Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 8.6
Server-side Request Forgery (SSRF)
SNYK-JS-IP-6240864
Yes Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: puppeteer The new version differs by 250 commits.
  • b33ff31 chore: release main (#11275)
  • 325fa8b feat: roll to Chrome 119.0.6045.105 (r1204232) (#11287)
  • f91a752 feat: update Node.js in Docker to 20 (#11296)
  • 887a862 docs: fix typo in troubleshooting guide (#11285)
  • d4a378a chore(deps): Bump the dependencies group with 1 update (#11295)
  • 6f60c2e chore(deps-dev): Bump the dev-dependencies group with 4 updates (#11294)
  • 019bc82 chore: update expected bidi errors (#11022)
  • b4b6fe2 chore: update chromium-bidi to 0.4.33 (#11284)
  • ce4e485 fix: ignore unordered frames (#11283)
  • be0dad4 chore(deps-dev): Bump the dev-dependencies group with 3 updates (#11281)
  • 0b756aa chore(deps): Bump the dependencies group with 2 updates (#11280)
  • ecb64e2 chore(deps): Bump the dependencies group with 2 updates (#11265)
  • 0d4aab8 chore: fix BiDi deserializer (#11264)
  • 22aeff1 fix: Type for ElementHandle.screenshot (#11274)
  • bec58dd chore(deps): Bump the all group with 1 update (#11272)
  • 4f999b3 fix(typs): lints in `puppeteer/docs` (#11251)
  • 8379f46 chore(deps): Bump acorn from 8.10.0 to 8.11.1 (#11262)
  • e0a5f68 test: unskip passing tests in Firefox (#11263)
  • 809aba2 chore(deps-dev): Bump the dev-dependencies group with 2 updates (#11252)
  • 9db4a94 refactor: remove extra variable on onTargetInfoChanged (#11249)
  • ab15aa5 ci: use the installed version rather than downloading (#11248)
  • f2ce480 ci: remove pgk mgr install to save time (#11243)
  • 530e068 chore: update firefox Expectations (#11242)
  • 133bbe7 chore(deps): Bump the dependencies group with 1 update (#11222)

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
馃 View latest project report

馃洜 Adjust project settings

馃摎 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

馃 Server-side Request Forgery (SSRF)

Copy link

stackblitz bot commented Feb 15, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

guardrails bot commented Feb 15, 2024

鈿狅笍 We detected 1 security issue in this pull request:

Vulnerable Libraries (1)
Severity Details
Medium pkg:npm/[email protected] (t) upgrade to: > 2.7.14

More info on how to fix Vulnerable Libraries in JavaScript.


馃憠 Go to the dashboard for detailed results.

馃摜 Happy? Share your feedback with us.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub 鈫楋笌

Package New capabilities Transitives Size Publisher
npm/[email protected] environment Transitive: filesystem, network, shell, unsafe +108 24.3 MB google-wombot

馃毊 Removed packages: npm/[email protected]

View full report鈫楋笌

Copy link

馃毃 Potential security issues detected. Learn more about Socket for GitHub 鈫楋笌

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Filesystem access npm/[email protected]
Network access npm/@tootallnate/[email protected]
Filesystem access npm/@tootallnate/[email protected]
Minified code npm/@tootallnate/[email protected]
Unmaintained npm/[email protected]
  • Last Publish: 2/13/2017, 5:14:56 PM
Modified license npm/[email protected]
  • License: Apache-2.0
  • Similarity: 0.99
Install scripts npm/[email protected]
Filesystem access npm/[email protected]
Shell access npm/[email protected]

View full report鈫楋笌

Next steps

What is filesystem access?

Accesses the file system, and could potentially read sensitive data.

If a package must read the file system, clarify what it will read and ensure it reads only what it claims to. If appropriate, packages can leave file system access to consumers and operate on data passed to it instead.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

What's wrong with minified code?

This package contains minified code. This may be harmless in some cases where minified code is included in packaged libraries, however packages on npm should not minify code.

In many cases minified code is harmless, however minified code can be used to hide a supply chain attack. Consider not shipping minified code on npm.

What are unmaintained packages?

Package has not been updated in more than 5 years and may be unmaintained. Problems with the package may go unaddressed.

Package should publish periodic maintenance releases if they are maintained, or deprecate if they have no intention in further maintenance.

What is a modified license?

(Experimental) Package contains a modified version of an SPDX license. Please read carefully before using this code.

Packages should avoid making modifications to standard licenses.

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants