Fix tm_player_transfer_history
#343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
==========================================
+ Coverage 61.15% 64.76% +3.61%
==========================================
Files 44 44
Lines 3586 3565 -21
==========================================
+ Hits 2193 2309 +116
+ Misses 1393 1256 -137 ☔ View full report in Codecov by Sentry. |
tonyelhabr
commented
Nov 23, 2023
| testthat::skip_on_cran() | ||
|
|
||
| ## multiple URLs | ||
| transfer_data <- tm_player_transfer_history( |
There was a problem hiding this comment.
augmented the test a bit while i was at it.
- explicit testing for multiple URLs
- explicit testing of
get_extra_info - checks for exact column names (this should be less frail than what we used to do for fotmob since we explicitly define the column names in the function code)
tonyelhabr
commented
Nov 23, 2023
|
|
||
| each_player_df <- rbind(each_player_df, each_row_df) | ||
| ) %>% | ||
| ## for backwards compatability |
There was a problem hiding this comment.
i.e. return the columns in the same order that they used to be returned
tonyelhabr
commented
Nov 23, 2023
| ) | ||
|
|
||
| # Executed if the user wants to get more info. Contains: Contract Expiring date + Days remaining. From which countries was the transfer. | ||
| res <- if (isTRUE(get_extra_info)) { |
There was a problem hiding this comment.
no actual logic changes for get_extra_info retrieval. just better spacing, etc.
JaseZiv
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "base" fields that used to be returned by
tm_player_transfer_history()are no longer provided via server-side rendered HTML. Instead, the data is loaded client-side after an API call. This PR refactors the logic to replicate the API call that a browser would make to retrieve the "base" fields liketeam_from,market_value, etc.The logic for the "extra" columns like
country_from,contract_expiryremains the same, although I've refactored it to be a little more elegant (usingpurrr::map()).Fixes #342.