Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NA goals returned from fb_match_results #340

Merged
merged 2 commits into from
Nov 5, 2023
Merged

Fix NA goals returned from fb_match_results #340

merged 2 commits into from
Nov 5, 2023

Conversation

tonyelhabr
Copy link
Collaborator

Fixes #326.

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2023

Codecov Report

Merging #340 (01ae55a) into main (9914697) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main     #340   +/-   ##
=======================================
  Coverage   62.96%   62.96%           
=======================================
  Files          44       44           
  Lines        3586     3586           
=======================================
  Hits         2258     2258           
  Misses       1328     1328           
Files Coverage Δ
R/get_match_results.R 62.09% <100.00%> (ø)

Copy link
Owner

@JaseZiv JaseZiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Thanks for addressing this

@JaseZiv JaseZiv merged commit 62ce06f into main Nov 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fb_match_results returning NA for goals
3 participants