Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed HTML change in tm_team_player_urls function #337

Merged
merged 3 commits into from
Nov 12, 2023

Conversation

drasbaek
Copy link
Contributor

Minor change fixing an error from a non-existing HTML node being chosen.

@JaseZiv
Copy link
Owner

JaseZiv commented Nov 12, 2023

Thanks @drasbaek for this PR.

Sorry it's taken so long to get to this!

I just added some commits to address the version bump and list the changes in NEWS.md.

@JaseZiv JaseZiv self-requested a review November 12, 2023 02:40
@JaseZiv
Copy link
Owner

JaseZiv commented Nov 12, 2023

The failed test has unearthed a new issue that I've raised here.

I will pass this one through and merge to main and address separately.

Thanks again @drasbaek for your contribution.

@JaseZiv JaseZiv merged commit 441ed6f into JaseZiv:main Nov 12, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants