Merge pull request github#11341 from hvitved/cfg/multi-edge-workaround

CFG: Workaround in test output for origin/target pairs with multiple edges
JanKallman · Nov 21, 2022 · d189ba5 · d189ba5
2 parents 78ad9ba + 0d89f57
commit d189ba5
Show file tree

Hide file tree

Showing 6 changed files with 37 additions and 25 deletions.
diff --git a/csharp/ql/lib/semmle/code/csharp/controlflow/internal/ControlFlowGraphImplShared.qll b/csharp/ql/lib/semmle/code/csharp/controlflow/internal/ControlFlowGraphImplShared.qll
@@ -907,9 +907,13 @@ module TestOutput {
 
  query predicate edges(RelevantNode pred, RelevantNode succ, string attr, string val) {
  attr = "semmle.label" and
- exists(SuccessorType t | succ = getASuccessor(pred, t) |
- if successorTypeIsSimple(t) then val = "" else val = t.toString()
- )
+ val =
+ strictconcat(SuccessorType t, string s |
+ succ = getASuccessor(pred, t) and
+ if successorTypeIsSimple(t) then s = "" else s = t.toString()
+ |
+ s, ", " order by s
+ )
  or
  attr = "semmle.order" and
  val =

diff --git a/csharp/ql/test/library-tests/controlflow/graph/NodeGraph.expected b/csharp/ql/test/library-tests/controlflow/graph/NodeGraph.expected
@@ -2775,7 +2775,7 @@ Assert.cs:
 #-----| true -> access to parameter b2
 
 # 140| [assertion failure] access to parameter b2
-#-----| false -> [assertion failure] access to parameter b3
+#-----| false, true -> [assertion failure] access to parameter b3
 
 # 140| access to parameter b2
 #-----| false -> [assertion success] access to parameter b3
@@ -4924,7 +4924,7 @@ ExitMethods.cs:
 #-----| -> ...;
 
 # 22| call to method ErrorAlways
-#-----| exception(Exception) -> exit M3 (abnormal)
+#-----| exception(ArgumentException), exception(Exception) -> exit M3 (abnormal)
 
 # 22| ...;
 #-----| -> true

diff --git a/ruby/ql/lib/codeql/ruby/controlflow/internal/ControlFlowGraphImplShared.qll b/ruby/ql/lib/codeql/ruby/controlflow/internal/ControlFlowGraphImplShared.qll
@@ -907,9 +907,13 @@ module TestOutput {
 
  query predicate edges(RelevantNode pred, RelevantNode succ, string attr, string val) {
  attr = "semmle.label" and
- exists(SuccessorType t | succ = getASuccessor(pred, t) |
- if successorTypeIsSimple(t) then val = "" else val = t.toString()
- )
+ val =
+ strictconcat(SuccessorType t, string s |
+ succ = getASuccessor(pred, t) and
+ if successorTypeIsSimple(t) then s = "" else s = t.toString()
+ |
+ s, ", " order by s
+ )
  or
  attr = "semmle.order" and
  val =

diff --git a/ruby/ql/test/library-tests/controlflow/graph/Cfg.expected b/ruby/ql/test/library-tests/controlflow/graph/Cfg.expected
@@ -811,7 +811,7 @@ case.rb:
 #-----| -> [ ..., * ]
 
 # 35| [ ..., * ]
-#-----| match -> x
+#-----| false, match, true -> x
 #-----| no-match -> in ... then ...
 
 # 35| x
@@ -821,7 +821,7 @@ case.rb:
 #-----| -> [ ..., * ]
 
 # 36| [ ..., * ]
-#-----| match -> x
+#-----| false, match, true -> x
 #-----| no-match -> in ... then ...
 
 # 36| x
@@ -836,7 +836,7 @@ case.rb:
 
 # 37| [ ..., * ]
 #-----| raise -> exit case_match_array (abnormal)
-#-----| match -> a
+#-----| false, match, true -> a
 
 # 37| a
 #-----| match -> b
@@ -881,7 +881,7 @@ case.rb:
 
 # 43| [ *,...,* ]
 #-----| raise -> exit case_match_find (abnormal)
-#-----| match -> x
+#-----| false, match, true -> x
 
 # 43| x
 #-----| -> 1
@@ -931,7 +931,7 @@ case.rb:
 #-----| no-match -> in ... then ...
 
 # 49| { ..., ** }
-#-----| match -> 1
+#-----| false, match, true -> 1
 #-----| no-match -> in ... then ...
 
 # 49| 1
@@ -952,7 +952,7 @@ case.rb:
 #-----| no-match -> in ... then ...
 
 # 50| { ..., ** }
-#-----| match -> 1
+#-----| false, match, true -> 1
 #-----| no-match -> in ... then ...
 
 # 50| 1
@@ -968,7 +968,7 @@ case.rb:
 
 # 51| { ..., ** }
 #-----| raise -> exit case_match_hash (abnormal)
-#-----| match -> case ...
+#-----| false, match, true -> case ...
 
 # 55| case_match_variable
 #-----| -> case_match_underscore
@@ -1372,7 +1372,7 @@ case.rb:
 
 # 91| { ..., ** }
 #-----| raise -> exit case_match_various (abnormal)
-#-----| match -> case ...
+#-----| false, match, true -> case ...
 
 # 95| case_match_guard_no_else
 #-----| -> exit case.rb (normal)
@@ -2559,7 +2559,7 @@ cfg.rb:
 #-----| -> type
 
 # 101| value
-#-----| no-match -> 42
+#-----| false, no-match, true -> 42
 #-----| match -> key
 
 # 101| 42
@@ -6535,7 +6535,7 @@ raise.rb:
 #-----| -> m11
 
 # 121| p
-#-----| no-match -> self
+#-----| false, no-match, true -> self
 #-----| match -> self
 
 # 121| call to raise

diff --git a/swift/ql/lib/codeql/swift/controlflow/internal/ControlFlowGraphImplShared.qll b/swift/ql/lib/codeql/swift/controlflow/internal/ControlFlowGraphImplShared.qll
@@ -907,9 +907,13 @@ module TestOutput {
 
  query predicate edges(RelevantNode pred, RelevantNode succ, string attr, string val) {
  attr = "semmle.label" and
- exists(SuccessorType t | succ = getASuccessor(pred, t) |
- if successorTypeIsSimple(t) then val = "" else val = t.toString()
- )
+ val =
+ strictconcat(SuccessorType t, string s |
+ succ = getASuccessor(pred, t) and
+ if successorTypeIsSimple(t) then s = "" else s = t.toString()
+ |
+ s, ", " order by s
+ )
  or
  attr = "semmle.order" and
  val =

diff --git a/swift/ql/test/library-tests/controlflow/graph/Cfg.expected b/swift/ql/test/library-tests/controlflow/graph/Cfg.expected
@@ -250,14 +250,14 @@ cfg.swift:
 #-----| match -> 0
 
 # 33| .error1
-#-----| no-match -> ... is ...
+#-----| match, no-match -> ... is ...
 
 # 33| ... is ...
-#-----| no-match -> call to isZero(x:)
+#-----| match, no-match -> call to isZero(x:)
 #-----| no-match -> case ...
 
 # 33| .error2
-#-----| no-match -> ... is ...
+#-----| match, no-match -> ... is ...
 
 # 33| ... is ... where ...
 #-----| -> .error2
@@ -1577,7 +1577,7 @@ cfg.swift:
 #-----| -> =~ ... where ...
 
 # 144| =~ ...
-#-----| no-match -> ... .&&(_:_:) ...
+#-----| match, no-match -> ... .&&(_:_:) ...
 #-----| no-match -> case ...
 
 # 144| x