Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 8396: filter out the empty field #8783

Merged
merged 5 commits into from
May 12, 2022
Merged

Fix for issue 8396: filter out the empty field #8783

merged 5 commits into from
May 12, 2022

Conversation

tomlinn
Copy link
Contributor

@tomlinn tomlinn commented May 10, 2022

Fixes #8396

Only show deprecated fields tab if they contain values

Descripion

Fixes #8396 by filtering out the empty deprecated fields.
The issue was caused because it always returns a valid deprecated field set but didn't check whether is empty or not.

JabRef version

5.4 (latest release)

Operating system

Mac OS

Details on version and operating system

Monterey 12.2.1

Before
Screen Shot 2022-05-10 at 1 38 47 PM
After
Screen Shot 2022-05-10 at 1 37 31 PM

PR Checklist

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr
Copy link
Member

Please check the codestyle, see here for how to impot the style https://github.com/JabRef/jabref/tree/main/config

@tomlinn tomlinn closed this May 10, 2022
@tomlinn tomlinn reopened this May 10, 2022
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 12, 2022
@Siedlerchr
Copy link
Member

I was so free to replace your solution with a more simple one liner to get that PR in asap.

@koppor koppor merged commit 8bd859d into JabRef:main May 12, 2022
@mlep
Copy link
Contributor

mlep commented May 13, 2022

@tomlinn Thank you for fixing this issue, hence making JabRef a better software! If you are looking for another issue to solve, this one is related to the Deprecated fields: #7757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only show deprecated fields tab if they contain values
4 participants