-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue 6959 #7151
Fix for issue 6959 #7151
Conversation
Please have a look at the failing checkstyle check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Two minor remarks from my side, then this is good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks for letting me contribute, I'll pick up another issue |
If you could fix the remaining checkstyle errors it would be fine:
|
Thanks again for your contribution! |
* upstream/master: Improve library loading UX (#7119) remove jython (#7157) Add missing authors Remove obsolete hint Fixed issue in PreviewView for number textfield (#7158) Fix for issue 6959 (#7151) Revert "remove jython (#7155)" (#7156) remove jython (#7155) Fix remembering password for sql db (#7154) Update to libre office 7.0.3 (#7150) Add IdBasedSearchFetcher to jstor (#7145) Squashed 'src/main/resources/csl-styles/' changes from 55200d0..a20406d Bump antlr4-runtime from 4.8-1 to 4.9 (#7136)
Fixes #6959 implementing the method
needsSharedDatabase
in theActionHelper
and then binding it in the classPullChangesFromSharedDatabase
. This solution prevents the user from clicking "Pull changes from database" if a shared database is not present.When the DatabaseLocation is local:
When the DatabaseLocation is shared:
When there is no library open: