-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable automated cross library search using a cross library query lan… #7124
Enable automated cross library search using a cross library query lan… #7124
Conversation
…guage. Signed-off-by: Dominik Voigt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot say anything about the functionality, but I have some suggestions/improvements for the code
...n/java/org/jabref/model/entry/types/SystematicLiteratureReviewStudyEntryTypeDefinitions.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides comments by @Siedlerchr LGTM
Signed-off-by: Dominik Voigt <[email protected]>
…test classes Signed-off-by: Dominik Voigt <[email protected]>
Signed-off-by: Dominik Voigt <[email protected]>
Two general questions:
Moreover, we should think about how to improve the experience for users trying out the feature the first time. Right now they are confronted with a file selection dialog, without any explanation of what they should actually select etc. |
Thanks for the feedback :)! Regarding the first bullet point: Regarding the second bullet point: I agree that the UX is currently poor, however with the GUI implementation and the existing documentation for the feature it should suffice :). |
I agree, and think it's a good short term solution. However, in the long term, I would strongly favor a solution based on a different file format. There are also parsers that can be reused easily.
That also works if the user manages the git repo on its own, right? Then one can also manually remove false-positives etc before commit.
Many users don't even know what a git repository is. |
Sure. The idea was as follows:
The user creates a separate branch (e.g., In other words: the SLR feature maintaines the branch
Future work: SLR feature switches to branch
With the upcoming GUI support, JabRef will create the git repository magically. No external dependencies required. The connection to an upstream repository is depatable. Maybe the thought-of target group is not that large as thought. Maybe a discussion with @xJREB could help here. Maybe, we should really do not do any git magic (push/pull), but leave that to the user. Nevertheless, I would keep the "branch switchting magic". The SLR feature only works at the branch |
That I fully understand. And I'm impressed by what Dominik accomplished in such a short time period. For the git support, it would maybe be good if you could outline what the goal and the workflow looks like. What are the use cases?
By skimming the code, I couldn't see how JabRef only maintains only the branch jabref-slr-search. It looked like it operates on the currently selected branch, and mostly commits everything (staged) - so even unrelated files in other directories. That might be undesired/unexpected from a user perspective. |
* upstream/master: (36 commits) Fix remembering password for sql db (#7154) Update to libre office 7.0.3 (#7150) Add IdBasedSearchFetcher to jstor (#7145) Squashed 'src/main/resources/csl-styles/' changes from 55200d0..a20406d Bump antlr4-runtime from 4.8-1 to 4.9 (#7136) Bump antlr4 from 4.8-1 to 4.9 (#7138) Bump mariadb-java-client from 2.7.0 to 2.7.1 (#7134) Bump classgraph from 4.8.90 to 4.8.92 (#7139) Bump mockito-core from 3.6.0 to 3.6.28 (#7135) Bump gittools/actions from v0.9.6 to v0.9.7 (#7144) Bump checkstyle from 8.37 to 8.38 (#7142) Add missing author Fix document viewer not showing first page (#7132) Add githandler mock to crawler test to fix NPE (#7133) Searchbar glyph icon colors in Dark Theme [FIXED] (#7131) Fix binding issue for the regex and case sensitive search buttons (#7125) Enable automated cross library search using a cross library query lan… (#7124) Add tracking Update Java Version Welcome Dominik ✌ ...
This PR adds the capabilities to perform certain aspects of literature studies.
Fixes koppor#369
It adds the capabilities to:
- Create studies and share the result with others using git
- Define certain aspects of the study, such as search terms and used E-Libraries
- Automatically crawl the specified E-Libraries and import their results to JabRef,
and merge the results of all E-Libraries into one result BibDatabase.
- Create diffs to inform the user of newly found publications since the last crawl.
- To filter the results of the crawling systematically.