Streamline new library command #6773

calixtus · 2020-08-19T19:46:22Z

This PR implements the changes, which were decided in the devcall in early june about the PR (#6539 (comment))
It merges the new library command in the toolbar and the file menu to always create a new library in the current default library mode and changes the label in the preferences.

Change in CHANGELOG.md described (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

c5f14e2 Update journal-of-plant-ecology.csl (#4837) b5d00ab Hotfix: pravnik.csl & iso690-full-note-cs.csl (#4833) fb8d48a add PMID and DOI (#4832) 7ebdfff Update lancaster-university-harvard.csl (#4836) 8771e21 Create journal-of-clinical-neurology.csl (#4835) 70beb7b Harvard Lancaster: Fix in-text locator 0709b73 Update informal-logic.csl (#4831) d18d133 Update gost-r-7-0-5-2008.csl (#4829) cfb5389 Update gost-r-7-0-5-2008-numeric.csl (#4828) 0fc46ea Update gost-r-7-0-5-2008-numeric-alphabetical.csl (#4827) fac26cb Create feminist-theory.csl (#4830) a2721e6 Update pravnik.csl, masarykova-univerzita-pravnicka-fakulta.csl, and iso690-full-note-cs.csl (#4826) 2f0d735 Improve localization of DGfP 683d7d1 Create zeitschrift-fur-theologie-und-philosophie.csl (#4813) 7c82406 always show DOI in aps.csl (#4820) 1eb531d Update journal-of-international-business-studies.csl (#4819) 9caf926 Create interdisziplinare-anthropologie.csl (#4818) 00210e1 UKSW2 (#4807) 015db6e UKSW1 (#4800) f706ef5 Update masarykova-univerzita-pravnicka-fakulta.csl (#4822) 096108d Update epilepsia.csl (#4823) 07ebdc3 Update eksploatacja-i-niezawodnosc.csl (#4824) 3d50f3c Create ABNT-Universidade-Federal-de-Pernambuco-CFCH.csl (#4798) df94fa1 Update eksploatacja-i-niezawodnosc.csl (#4808) 4089be5 Update bulletin-de-la-societe-prehistorique-francaise.csl (#4810) f130aa7 Update molecular-biology-and-evolution.csl (#4814) 86f452f Create heiliger-dienst.csl (#4815) 5ccd3e9 Update revista-brasileira-de-ciencia-do-solo.csl (#4817) 0eea734 Fix a delimiter in journal-of-the-royal-society-of-western-australia.csl (#4811) 1cbe790 Delete heiliger-dienst.csl 19fa29f Create heiliger-dienst.csl (#4787) 888bad1 Update RMIT Harvard to match Easy Cite (#4788) 46011dd Create universite-nangui-abrogoua-ufr-sn (#4676) 174adab Create apa-6th-edition-no-ampersand.csl (#4767) 03cf65f Create journal-of-plant-protection-research.csl (#4797) c749084 Update eksploatacja-i-niezawodnosc.csl (#4782) 17e1501 Update masarykova-univerzita-pravnicka-fakulta.csl (#4783) 5596d18 Update revista-brasileira-de-ciencia-do-solo.csl (#4790) 9c1a381 create csl for the journal Textual Cultures (#4785) 8345762 Update taylor-and-francis-national-library-of-medicine.csl (#4786) 5ec1acf Create british-journal-of-criminology.csl (#4789) 68550ac Update angewandte-chemie.csl (#4791) 09e2755 Create shock.csl (#4792) d46e49e Update antioxidants-and-redox-signaling.csl (#4793) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: c5f14e2

716f635 Update changes in Harvard-Stellenbosch (#4862) a6a9a1a Create alkoholizmus-a-drogove-zavislosti.csl (#4859) 0560ca0 Update journal-of-the-american-college-of-surgeons.csl (#4858) 9e16631 create independent style for cellular-and-molecular-gastroenterology-and-hepatology.csl (#4852) 87b0853 Update antiquity.csl (#4841) cb4e7f7 Update heart-rhythm.csl (#4850) b3b55ee Create iisue-moderno (#4846) 63973a7 Create etasr.csl (#4848) 9942138 Create style for Journal of Vertebrate Biology (#4849) 7c7f3d3 Add Future Medicine dependents (#4838) abe2066 Update methods-of-information-in-medicine.csl (#4847) c64d98b create independent style for new-zealand-journal-of-forestry-science (#4844) 28265f9 Create continuity-and-change.csl (#4839) d065fdd Create journal-of-clinical-ethics.csl (#4842) b9fbfa3 Update future-medicine.csl (#4843) ceb56fa Create future-medicine.csl (#4834) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 716f635

a995c63 Create errata.csl (#4894) 883b9cd Update archeologie-medievale.csl (#4892) a942b5c Update rmit-university-harvard.csl (#4890) 5d535fc Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (#4891) f2a8fe3 Fix AVMA style c5a2d7e Create universidade-do-porto-faculdade-de-engenharia-chicago.csl (#4872) 9f106eb Update rmit-university-harvard.csl (#4884) 5213c2f Update universitetet-i-oslo-rettsvitenskap.csl (#4886) 7e0828d Update uclouvain-centre-charles-de-visscher-pour-le-droit-internation… (#4871) ae5eba3 Create revue-archeologique-de-lest.csl (#4881) 58a1672 Create pacific-conservation-biology.csl (#4880) 381106e Update national-institute-of-organisation-dynamics-australia-harvard.csl (#4879) c66a5c0 Create society-of-biblical-literature-author-date.csl (#4812) 008073c Create ruhr-universitat-bochum-medizinische-fakultat-variante-a.csl (#4874) 193385a Update manchester (#4878) fa9ef11 Create Faculty of Psychology and Education Sciences, Porto (#4856) 2f70b14 Add "personal communication" to remaining APA locales (#4866) 2b4f831 Fixed page-range-format (#4863) d5661ba universitat-bern-institut-fur-musikwissenschaft add missing cs:sort to cs:bibliography (#4860) e433c99 fix delimiter issue for bioscience.csl (#4876) 4d97aab update et-al settings for stroke.csl (#4875) 342b9e3 Update masarykova-univerzita-pravnicka-fakulta.csl (#4868) 91fe25e Add article number to IEEE (#4867) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: a995c63

bf698ac Create common-market-law-review.csl (#4910) c962eca Create harvard-prifysgol-caerdydd.csl (#4922) 0c24e7f Update gewerblicher-rechtsschutz-und-urheberrecht.csl (#4923) d2ec1a7 Create Tijdschrift-voor-Geneeskunde.csl (#4907) 5df7250 Update harvard-institut-fur-praxisforschung-de.csl (#4918) 093fd91 Update universite-de-montreal-apa.csl (#4916) a3e41d4 Update thieme-german.csl (#4919) 648765a add DOI to aerosol-science-and-technology.csl (#4909) bc1ebee Reindent/reorder a8dc18a Fix documentation link for epidemiology & infection aab403a Fix AGLC Newspaper date 4c018d5 Add period between editor and translator (SBL styles) (#4906) 42f7491 Create geographische-zeitschrift.csl (#4898) a4002a6 Create german-kunstwissenschaft.csl (#4896) b01910b Disambiguation of names (#4895) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: bf698ac

7cab2f7 Create depro-ufs.csl (#4947) 2fcda1f Create journal-of-sport-science-and-medicine.csl (#4949) cd457d4 Update american-marketing-association.csl (#4945) cacc4ee Create nejm-catalyst.csl (#4943) bd769b9 Update and rename dependent/chinese-medical-journal.csl to chinese-me… (#4941) 1f706cd Update health-services-research.csl (#4939) 76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (#4932) e79640e Create afro-asia.csl (#4934) c601aa4 Update lancaster-university-harvard.csl (#4938) 184fd90 Update collection-du-centre-jean-berard.csl (#4936) 82f9aec fix et-al & add DOI thyroid.csl (#4937) 4af169f Create universidade-estadual-de-alagoas-uneal-abnt (#4885) 47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (#4905) 3cab27d Update thieme-german.csl (#4931) eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (#4925) 4adb1ea Create karstenia.csl (#4929) 530a136 Fix author substitute in Universita Cattolica git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 7cab2f7

827b986 add DOI preprint to american-society-for-microbiology.csl (#4946) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 827b986

eb0d37e Create natbib-plainnat-author-dat.csl (#4967) fb1592a Update journal-of-fish-biology.csl (#4969) f6876cb Update .travis.yml (#4970) d6d400b Create london-review-of-international-law.csl (#4966) d2a5ae1 Update harvard-stellenbosch-university.csl (#4965) 9c62141 Create phytopathologia-mediterranea.csl (#4964) 8ca2ea1 Update historical-materialism.csl (#4960) 80456dc Update historical-materialism.csl be2d910 Update historical-materialism.csl 1d1cf09 Create atlande.csl (#4930) 89f41d4 Create juristische-zitierweise-oeffentliches-recht.csl (#4944) 8c677a0 Create korean-journal-of-gastroenterology.csl (#4954) eadb950 Create historical-materialism.csl (#4955) 5553dcd Create revista-materia.csl (#4957) d23a3ab Bug fix in APA 6 original publication macro (#4959) 66f9974 Always print publisher in APA 6th edition (#4899) 868809c Create agora.csl (#4940) 99c19c3 Update anthropologie-et-societes.csl (#4952) ee17423 Create critical-reviews-in-solid-state-and-materials-science.csl (#4951) 7a13a7d Create korean-journal-of-internal-medicine.csl (#4953) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: eb0d37e

github-actions · 2020-08-19T19:47:09Z

The JabRef maintainers will add the following name to the AUTHORS file. In case you want to use a different one, please comment here and adjust your name in your git configuration for future commits.

Marcel Luethi
Qing
ShiqingLiu
WangAooa

tobiasdiez

Nice job.

tobiasdiez · 2020-08-20T07:24:26Z

src/main/java/org/jabref/gui/importer/NewDatabaseAction.java

+     * @param preferencesService the preferencesService of JabRef
+     * @param mode the mode the new library is created in (BibTeX or biblatex)
+     */
+    public NewDatabaseAction(JabRefFrame jabRefFrame, PreferencesService preferencesService, BibDatabaseMode mode) {


Is this constructor used somewhere? (I couldn't find it in the changelog, but maybe I'm missing something).
If not then, the mode and shouldUseDefaultMode variables can be deleted as well.

No, I just thought I could leave it in, if someone decides to create a specific type of a library. Just a thought...

I'm not a big fan of unused/dead code...

meh... 😉

tobiasdiez

Thanks ;-).

Can be merged from my point of view. However, checkstyle is failing again.

calixtus · 2020-08-20T13:38:25Z

of course, i missed two useless imports... argh. 🤦

* upstream/master: Streamline new library command (#6773) [6574] Added support for biblatex-software (#6747) Updated the eclipse doc with a note and image on how to add the run/debug configuration. (#6776) New Crowdin updates (#6774)

github actions and others added 18 commits June 1, 2020 02:09

Merge commit '7629ee29c5b60711da5d1c64f8c2c8e146e90d6f'

5f72ad3

Merge commit '52a64264feb20ea3506f7f11e70fcf24ec768682'

f678e52

Merge commit '88872055561d37157537aece4b5d9fa859a138e9'

47bbd31

Merge commit '230305ff8acf22110d88d441b552e634f17e0a6e'

8cdb629

Merge commit '73420559d42065980d8dbbe6be6825f5a2e3ab18'

5fd80c2

Squashed 'src/main/resources/csl-styles/' changes from 7cab2f7..827b986

877a0c4

827b986 add DOI preprint to american-society-for-microbiology.csl (#4946) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 827b986

Merge commit '877a0c4daf0117d4f910a5c5b679ad824c63bda9'

1541cd1

Merge commit '7ff46331ad541719aad203eb33d44e21db721554' into master

8f1de8e

Merge remote-tracking branch 'origin/master' into master

1bc3681

Merge remote-tracking branch 'upstream/master' into master

98bfe5a

Merged new library actions

f482de6

l10n

8e41efd

calixtus added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 19, 2020

tobiasdiez reviewed Aug 20, 2020

View reviewed changes

Removed unused constructor

d37a3dd

tobiasdiez approved these changes Aug 20, 2020

View reviewed changes

Fixed checkstyle failed check

262d29d

Fixed one more checkstyle issue

3e27db6

Siedlerchr approved these changes Aug 22, 2020

View reviewed changes

Siedlerchr merged commit dc55a76 into master Aug 22, 2020

Siedlerchr deleted the streamlineNewLibrary branch August 22, 2020 14:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Streamline new library command #6773

Streamline new library command #6773

calixtus commented Aug 19, 2020 •

edited

Loading

github-actions bot commented Aug 19, 2020

tobiasdiez left a comment

tobiasdiez Aug 20, 2020

calixtus Aug 20, 2020

tobiasdiez Aug 20, 2020

calixtus Aug 20, 2020

tobiasdiez left a comment

calixtus commented Aug 20, 2020

Streamline new library command #6773

Streamline new library command #6773

Conversation

calixtus commented Aug 19, 2020 • edited Loading

github-actions bot commented Aug 19, 2020

tobiasdiez left a comment

Choose a reason for hiding this comment

tobiasdiez Aug 20, 2020

Choose a reason for hiding this comment

calixtus Aug 20, 2020

Choose a reason for hiding this comment

tobiasdiez Aug 20, 2020

Choose a reason for hiding this comment

calixtus Aug 20, 2020

Choose a reason for hiding this comment

tobiasdiez left a comment

Choose a reason for hiding this comment

calixtus commented Aug 20, 2020

calixtus commented Aug 19, 2020 •

edited

Loading