Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.javamodularity.moduleplugin from 1.5.0 to 1.7.0 #6549

Merged

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps org.javamodularity.moduleplugin from 1.5.0 to 1.7.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

If all status checks pass Dependabot will automatically merge this pull request.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps org.javamodularity.moduleplugin from 1.5.0 to 1.7.0.

Signed-off-by: dependabot-preview[bot] <[email protected]>
@dependabot-preview
Copy link
Contributor Author

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@tobiasdiez
Copy link
Member

So this seems to work in principle. Let's wait a bit, maybe the javafx guys release 0.0.9 soon (refs openjfx/javafx-gradle-plugin#59).

@Siedlerchr can you please test if the additions in the new 1.7 make life for eclipse easier: https://github.com/java9-modularity/gradle-modules-plugin#improve-eclipse-classpath-file

@tobiasdiez tobiasdiez added status: changes required Pull requests that are not yet complete status: depends-on-external A bug or issue that depends on an update of an external library labels Jun 5, 2020
@dependabot-preview
Copy link
Contributor Author

This pull request will no longer be automatically closed when a new version is found as this pull request was created by Dependabot Preview and this repo is using a version: 2 config file. You can close this pull request and let Dependabot re-create it the next time it checks for updates.

@Siedlerchr Siedlerchr closed this Jun 30, 2020
@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot-preview dependabot-preview bot deleted the dependabot/gradle/org.javamodularity.moduleplugin-1.7.0 branch June 30, 2020 10:57
@tobiasdiez tobiasdiez restored the dependabot/gradle/org.javamodularity.moduleplugin-1.7.0 branch June 30, 2020 11:02
@tobiasdiez tobiasdiez reopened this Jun 30, 2020
@Siedlerchr
Copy link
Member

I've reverted the applications insight changes into master because they are also breaking the build

@tobiasdiez
Copy link
Member

Since this PR also fixes the current build issues (mea culpa :(), I'll merge it now.

@Siedlerchr can you please test if the additions in the new 1.7 make life for eclipse easier: https://github.com/java9-modularity/gradle-modules-plugin#improve-eclipse-classpath-file

@tobiasdiez tobiasdiez merged commit beece6a into master Jun 30, 2020
@tobiasdiez tobiasdiez deleted the dependabot/gradle/org.javamodularity.moduleplugin-1.7.0 branch June 30, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: changes required Pull requests that are not yet complete status: depends-on-external A bug or issue that depends on an update of an external library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants