Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve parser warnings #4702

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Improve parser warnings #4702

merged 1 commit into from
Feb 27, 2019

Conversation

tobiasdiez
Copy link
Member

Based on https://discourse.jabref.org/t/warnings-by-jabref-start/1532, in which a user (rightfully) complained that the error message is not very helpful.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@tobiasdiez
Improve parser warnings
fbc30bf 
Based on https://discourse.jabref.org/t/warnings-by-jabref-start/1532, in which a user (rightfully) complained that the error message is not very helpful.
@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 26, 2019
@Siedlerchr Siedlerchr merged commit 3cf609c into master Feb 27, 2019
@Siedlerchr Siedlerchr deleted the improvWarnings branch February 27, 2019 07:27
Siedlerchr added a commit that referenced this pull request Mar 1, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into libraryproperties…
f6564f1 
…tofx

* upstream/master:
  Bump fontbox from 2.0.13 to 2.0.14 (#4705)
  Bump pdfbox from 2.0.13 to 2.0.14 (#4706)
  Bump xmpbox from 2.0.13 to 2.0.14 (#4704)
  Improve parser warnings (#4702)
  Bump checkstyle from 8.17 to 8.18 (#4700)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasdiez @Siedlerchr