Initial shot for snapcraft.yaml #2345

koppor · 2016-12-07T23:57:22Z

Future tracking of SnapCraft at #3121

This outlines how we could get into the app store of Ubuntu (https://developer.ubuntu.com/en/desktop/ and https://shop.canonical.com/index.php?cPath=19). The issue is that snap is only supported in Ubuntu 16.04 LTS. ~~Thus, this PR fails. We have to interpret following gist https://gist.github.com/evandandrea/c754964bfdfb176844f26f605ebbb8db and try to adapt it.~~

~~It seems that the IRC channel is the only help out there. The gradle support is very new (see canonical/snapcraft#912).~~

~~Is there some Linuxer out there who wants to take over?~~

Howto install and update

snap install jabref --edge --devmode
snap refresh jabref --edge --devmode

Current state

Steps after merging

~~adapt travis.yml to build snap only at the master branch (and not snapcraft).~~

Howto build locally

docker run -it -v /d/git-repositories/jabref/jabref:/tmp/snap koppor/docker-snapcraft-java-de bash
cd /tmp/jabref
Read along at https://snapcraft.io/docs/build-snaps/publish

References

koppor · 2017-07-23T14:10:11Z

I currently cannot test, no working VM with X11. Maybe someone else has?

Siedlerchr · 2017-07-28T13:21:11Z

I get the same problems with the diriver:

libGL error: unable to load driver: swrast_dri.so
libGL error: failed to load driver: swrast
X Error:  BadValue
  Request Major code 154 (GLX)
  Request Minor code 24 ()
  Value 0x0
  Error Serial #32
  Current Serial #33

I found this issues which are similar and there seems to be some libgl stuff missing or whatever (not an expert in that area)
https://forum.snapcraft.io/t/build-fotoxx-snap-need-help/1355/14
https://forum.snapcraft.io/t/libgl-error-unable-to-load-driver-i965-dri-so/733

LinusDietz · 2017-08-08T08:29:05Z

@koppor do you think this is feasible for 4.0? I would really like to include this in 4.0, but then we would have to include it into a beta version, so people can test it.

koppor · 2017-08-08T08:36:30Z

Yes, I do think so. We also testers, so it is a very good idea to include it in beta-3.

stefan-kolb · 2017-08-08T15:19:08Z

.gitignore

@@ -51,83 +51,23 @@ jabref.xml



-# Created by https://www.gitignore.io/api/gradle,java,jabref,intellij,eclipse,netbeans,windows,linux,macos


What happened to the gitignore? This diff seems strange to me if I think about the purpose of the PR.

Yeah, I just regenerated it - i regenerated using gitigonre.io 😇

More specifically, I added snapcraft to the API call. Instead of sorting the updates out, I just replaced the whole output

Created by https://www.gitignore.io/api/gradle,java,jabref,intellij,eclipse,netbeans,windows,linux,macos,snapcraft

stefan-kolb · 2017-08-08T15:20:08Z

.gitignore

@@ -269,4 +296,5 @@ gradle-app.setting

 # # Work around https://youtrack.jetbrains.com/issue/IDEA-116898
 # gradle/wrapper/gradle-wrapper.properties
-scenicView.properties
+
+# End of https://www.gitignore.io/api/gradle,java,jabref,intellij,eclipse,netbeans,windows,linux,macos,snapcraft


What is this binary file below good for?

.snapcraft/travis_snapcraft.cfg is the travis-encrypted file with my personal credentials enabling an upload to the Ubuntu app store.

stefan-kolb · 2017-08-08T15:24:02Z

.travis.yml

  - if [ "$TEST_SUITE" == "checkstyle" ]; then ./gradlew checkstyleMain checkstyleTest checkstyleJmh; fi
  - if [ "$TEST_SUITE" == "guiTest" ]; then ./buildres/gui-tests.sh; fi

 after_success:
  # enable codecov report
-  - ./gradlew jacocoTestReport
-  - bash <(curl -s https://codecov.io/bash)
+  - if [ "$TEST_SUITE" != "checkstyle" ] && [ "$TEST_SUITE" != "snapcraft" ]; then ./gradlew jacocoTestReport && bash <(curl -s https://codecov.io/bash); fi


What happens here? Why do you run it with checkstyle && snapcraft only?

not checkstyle and not snapcraft makes guitest and normal test... checkstyle does not run any tests and snapcroft doesn't too.

stefan-kolb · 2017-08-08T15:29:58Z

build.gradle

            rename { String fileName ->
                fileName.replace('-fat', '')
            }
        }
+        file("$buildDir/releases/JabRef-${project.version}.jar").setExecutable(true, true);


Why owner only? https://docs.oracle.com/javase/8/docs/api/java/io/File.html#setReadable-boolean-boolean-

stefan-kolb · 2017-08-08T15:31:47Z

snapcraft.yaml

+# based on https://github.com/snapcore/snapcraft/blob/master/demos/gradle/snap/snapcraft.yaml
+
+name: jabref
+version: '4.0-dev'


This value needs to be documented (that it has to be changed) if it cannot be parametrized.

run-snapcraft.sh line 3: The value is changed upon run

I'll document that.

stefan-kolb · 2017-08-08T15:34:34Z

It's not so cool that we mix our build environments again but hey...

koppor · 2017-08-08T15:51:55Z

Yeah, I also don't like it. However, snapcraft is supported for CircleCI 2.0 only. I tried to port our build to CircleCI 2.0 at https://github.com/JabRef/jabref/tree/circleci20, but I did not succeed. Needs much more work...

Siedlerchr · 2017-08-08T16:37:38Z

We can also use launchpad to build snaps: It checks for new commits 4 times a day from github:
https://snapcraft.io/docs/build-snaps/ci-integration

Siedlerchr · 2017-08-09T16:40:40Z

While JabRef now starts and runs fine, I still get the xprops error:

java.io.IOException: Cannot run program "/usr/bin/xprop": error=2, No such file or directory
	at java.lang.ProcessBuilder.start(ProcessBuilder.java:1048)
	at java.lang.Runtime.exec(Runtime.java:620)
	at java.lang.Runtime.exec(Runtime.java:450)
	at java.lang.Runtime.exec(Runtime.java:347)
	at org.GNOME.Accessibility.AtkWrapper.<clinit>(AtkWrapper.java:34)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
	at java.lang.Class.newInstance(Class.java:442)
	at java.awt.Toolkit.loadAssistiveTechnologies(Toolkit.java:805)
	at java.awt.Toolkit.getDefaultToolkit(Toolkit.java:886)
	at java.awt.Toolkit.getEventQueue(Toolkit.java:1734)
	at java.awt.EventQueue.invokeLater(EventQueue.java:1266)
	at javax.swing.SwingUtilities.invokeLater(SwingUtilities.java:1290)
	at org.jabref.JabRefMain.start(JabRefMain.java:53)
	at com.sun.javafx.application.LauncherImpl.lambda$launchApplication1$8(LauncherImpl.java:863)
	at com.sun.javafx.application.PlatformImpl.lambda$runAndWait$7(PlatformImpl.java:326)
	at com.sun.javafx.application.PlatformImpl.lambda$null$5(PlatformImpl.java:295)
	at java.security.AccessController.doPrivileged(Native Method)
	at com.sun.javafx.application.PlatformImpl.lambda$runLater$6(PlatformImpl.java:294)
	at com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:95)
	at com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method)
	at com.sun.glass.ui.gtk.GtkApplication.lambda$null$5(GtkApplication.java:139)
	at java.lang.Thread.run(Thread.java:748)
Caused by: java.io.IOException: error=2, No such file or directory
	at java.lang.UNIXProcess.forkAndExec(Native Method)
	at java.lang.UNIXProcess.<init>(UNIXProcess.java:247)
	at java.lang.ProcessImpl.start(ProcessImpl.java:134)
	at java.lang.ProcessBuilder.start(ProcessBuilder.java:1029)
	... 24 more

koppor · 2017-08-10T09:59:57Z

I don't get the reason for the issue with x11-prop. x11-utils is included in the snap build: https://github.com/JabRef/jabref/pull/2345/files#diff-184032a532406b07009403e26f4fc62fR24 and:

$ apt-cache search xprop
x11-utils - X11 utilities

…raft.io

Siedlerchr · 2017-08-10T13:54:43Z

I get the same output, and locate xprop says:

/usr/bin/xprop
/usr/share/man/man1/xprop.1.gz

As these ATK is some gnome stuff, I believe it has to do with my Xfce desktop environment. So maybe someone with gnome or KDE can test this

I also tried to install java-atk-wrapper, not still same error
https://launchpad.net/ubuntu/+source/java-atk-wrapper

koppor · 2017-08-10T13:59:00Z

I would propose

Merge this PR
me tries to get ~~https://snapcraft.io/docs/build-snaps/ci-integration~~https://build.snapcraft.io/ running
In parallel, we fix snapcraft.yml via PRs
If the issue is fixed, we can make a JabRef release also on SnapCraft.

koppor · 2017-08-11T17:00:53Z

The current state does not change our build system
I worked in the comments of @stefan-kolb in build.gradle
@Siedlerchr agreed to Initial shot for snapcraft.yaml #2345 (comment)

Thus, I merge. 😇

koppor · 2017-08-11T17:31:27Z

Current state: gradle binary cannot be downloaded from https://build.snapcraft.io. See: canonical-web-and-design/build.snapcraft.io#918

koppor · 2017-08-16T09:17:17Z

The new location is handled at #3107.

koppor · 2017-08-18T07:37:56Z

Future tracking of SnapCraft is tracked at #3121

koppor mentioned this pull request Dec 7, 2016

Add Jabref to app stores #1371

Closed

6 tasks

koppor force-pushed the snapcraft branch 2 times, most recently from 69f05c2 to a7a8b3e Compare July 19, 2017 05:29

koppor added the os: linux label Jul 19, 2017

koppor force-pushed the snapcraft branch 21 times, most recently from 9b71e35 to af78a63 Compare July 23, 2017 13:31

koppor mentioned this pull request Jul 23, 2017

Nullpointer exception #3021

Closed

koppor added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Jul 23, 2017

koppor changed the title ~~[WIP] Initial shot for snapcraft.yaml~~ Initial shot for snapcraft.yaml Jul 23, 2017

koppor force-pushed the snapcraft branch 2 times, most recently from d4be7e5 to c2f1bfb Compare August 8, 2017 06:18

koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 8, 2017

koppor changed the title ~~[WIP] Initial shot for snapcraft.yaml~~ Initial shot for snapcraft.yaml Aug 8, 2017

LinusDietz added this to the v4.0 milestone Aug 8, 2017

stefan-kolb reviewed Aug 8, 2017

View reviewed changes

koppor mentioned this pull request Aug 10, 2017

Update .gitignore #3091

Merged

koppor mentioned this pull request Aug 10, 2017

JabRef freeze in opening entry editor #2963

Closed

koppor changed the title ~~Initial shot for snapcraft.yaml~~ [WIP] Initial shot for snapcraft.yaml Aug 10, 2017

koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 10, 2017

Initial version for snapcraft.yaml to enable building via build.snapc…

c2fb270

…raft.io

koppor force-pushed the snapcraft branch from 3e40010 to c2fb270 Compare August 10, 2017 13:19

koppor changed the title ~~[WIP] Initial shot for snapcraft.yaml~~ Initial shot for snapcraft.yaml Aug 10, 2017

koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 10, 2017

koppor merged commit 18fffc6 into master Aug 11, 2017

koppor deleted the snapcraft branch August 11, 2017 17:01

koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 11, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial shot for snapcraft.yaml #2345

Initial shot for snapcraft.yaml #2345

koppor commented Dec 7, 2016 •

edited

Loading

koppor commented Jul 23, 2017

Siedlerchr commented Jul 28, 2017 •

edited

Loading

LinusDietz commented Aug 8, 2017

koppor commented Aug 8, 2017

stefan-kolb Aug 8, 2017

koppor Aug 8, 2017 •

edited

Loading

koppor Aug 8, 2017

stefan-kolb Aug 8, 2017

koppor Aug 8, 2017

stefan-kolb Aug 8, 2017

koppor Aug 8, 2017

stefan-kolb Aug 8, 2017

stefan-kolb Aug 8, 2017

koppor Aug 8, 2017

koppor Aug 8, 2017

stefan-kolb commented Aug 8, 2017

koppor commented Aug 8, 2017

Siedlerchr commented Aug 8, 2017

Siedlerchr commented Aug 9, 2017

koppor commented Aug 10, 2017 •

edited

Loading

Siedlerchr commented Aug 10, 2017

koppor commented Aug 10, 2017 •

edited

Loading

koppor commented Aug 11, 2017

koppor commented Aug 11, 2017

koppor commented Aug 16, 2017

koppor commented Aug 18, 2017

		@@ -51,83 +51,23 @@ jabref.xml



		# Created by https://www.gitignore.io/api/gradle,java,jabref,intellij,eclipse,netbeans,windows,linux,macos

Initial shot for snapcraft.yaml #2345

Initial shot for snapcraft.yaml #2345

Conversation

koppor commented Dec 7, 2016 • edited Loading

Howto install and update

Current state

Steps after merging

Howto build locally

References

koppor commented Jul 23, 2017

Siedlerchr commented Jul 28, 2017 • edited Loading

LinusDietz commented Aug 8, 2017

koppor commented Aug 8, 2017

Choose a reason for hiding this comment

koppor Aug 8, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stefan-kolb commented Aug 8, 2017

koppor commented Aug 8, 2017

Siedlerchr commented Aug 8, 2017

Siedlerchr commented Aug 9, 2017

koppor commented Aug 10, 2017 • edited Loading

Siedlerchr commented Aug 10, 2017

koppor commented Aug 10, 2017 • edited Loading

koppor commented Aug 11, 2017

koppor commented Aug 11, 2017

koppor commented Aug 16, 2017

koppor commented Aug 18, 2017

koppor commented Dec 7, 2016 •

edited

Loading

Siedlerchr commented Jul 28, 2017 •

edited

Loading

koppor Aug 8, 2017 •

edited

Loading

koppor commented Aug 10, 2017 •

edited

Loading

koppor commented Aug 10, 2017 •

edited

Loading