AI: chatting with papers #11427
Closed
AI: chatting with papers #11427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' into ai-1 # Conflicts: # src/main/java/org/jabref/gui/preferences/ai/AiTab.java # src/main/java/org/jabref/gui/preferences/ai/AiTabViewModel.java # src/main/java/org/jabref/preferences/AiPreferences.java # src/main/java/org/jabref/preferences/JabRefPreferences.java
# Conflicts: # src/main/java/org/jabref/gui/preferences/ai/AiTab.fxml # src/main/java/org/jabref/gui/preferences/ai/AiTab.java # src/main/java/org/jabref/gui/preferences/ai/AiTabViewModel.java # src/main/java/org/jabref/preferences/AiPreferences.java # src/main/java/org/jabref/preferences/JabRefPreferences.java
# Conflicts: # src/main/java/module-info.java # src/main/java/org/jabref/gui/ai/components/JabRefMarkdownView.java # src/main/java/org/jabref/gui/ai/components/aichat/AiChatComponent.fxml # src/main/java/org/jabref/gui/ai/components/aichat/AiChatComponent.java # src/main/java/org/jabref/gui/ai/components/chatmessage/ChatMessageComponent.fxml # src/main/java/org/jabref/gui/ai/components/chatmessage/ChatMessageComponent.java
# Conflicts: # src/main/java/org/jabref/gui/DefaultInjector.java # src/main/java/org/jabref/gui/JabRefGUI.java # src/main/java/org/jabref/gui/LibraryTab.java # src/main/java/org/jabref/gui/entryeditor/EntryEditor.java # src/main/java/org/jabref/gui/externalfiles/ImportHandler.java # src/main/java/org/jabref/gui/frame/JabRefFrame.java # src/main/java/org/jabref/gui/frame/JabRefFrameViewModel.java # src/main/java/org/jabref/gui/frame/MainToolBar.java # src/main/java/org/jabref/gui/importer/actions/OpenDatabaseAction.java # src/main/java/org/jabref/gui/openoffice/OpenOfficePanel.java # src/main/java/org/jabref/gui/preferences/PreferencesDialogViewModel.java # src/main/java/org/jabref/gui/sidepane/SidePaneContentFactory.java
# Conflicts: # build.gradle # src/main/java/module-info.java
|
So the checkstyle has issues with the switch statement in the MvStoreembeddings |
Siedlerchr
reviewed
Jun 25, 2024
| return switch (filter) { | ||
| case null -> embeddingsMap.keySet().stream(); | ||
|
|
||
| case IsIn isInFilter when Objects.equals(isInFilter.key(), "linkedFile") -> |
There was a problem hiding this comment.
When I saw the error messages correctly, this is the part where checkstyle fails.
Can you verify this locally with running checkstyle?
I found related issues
|
The out of memory seems to be related to linux arm only in jlink. Sorry to tell ya, but can you please push the branch to upstream (jabref/jabref) repo and recreate the PR ? Then we can get the binaries uploaded and test them for any module errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)