Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more JavaDoc #11400

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Add some more JavaDoc #11400

merged 1 commit into from
Jun 20, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Jun 20, 2024

Follow-up to #11271

Side comment: I wonder why that PR fixed #8933. The hashCode was introduced at #10776, which was implemented after the issue appeared.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added the type: code-quality Issues related to code or architecture decisions label Jun 20, 2024
@koppor koppor requested a review from LoayGhreeb June 20, 2024 11:36
Copy link
Contributor

github-actions bot commented Jun 20, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit 931e4c8 Jun 20, 2024
22 checks passed
@Siedlerchr Siedlerchr deleted the add-javadoc branch June 20, 2024 13:43
@Siedlerchr
Copy link
Member

Maybe we should exclude database from hashcode? Because getUID also does not really solve the problem as two instances of bibdatabasecontext will never be "equal" as each one gets a new uid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: code-quality Issues related to code or architecture decisions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New entry: not always added to the selected group
2 participants