Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move 'Add group' button somewhere closer to groups #8398

Open
ThiloteE opened this issue Jan 7, 2022 · 12 comments
Open

Move 'Add group' button somewhere closer to groups #8398

ThiloteE opened this issue Jan 7, 2022 · 12 comments

Comments

@ThiloteE
Copy link
Member

ThiloteE commented Jan 7, 2022

Problem:
When i first started using Jabref I vividly remember that i could not find the add groups button immediately, because i first found the Groups and Filter groups field and naively thought, the add groups button must be close to that. Or to say it differently: The Add group button is so close to the Web search panel, that on first glance it will be associated with it. Try to look at Jabref from a far distance and you might see what i mean.

Desired Solution:

Move the Add group button somewhere closer to groups.

Maybe it could be

  • Between Filter groups and All entries.
    OR
  • Between Groups and Filter groups
    OR
  • Beneath the last group

Additional context
image

@mlep
Copy link
Contributor

mlep commented Jan 18, 2022

At the moment (JabRef 5.6--2022-01-17--e0e7191), the Web search and OpenOffice/LibreOffice panels are always "condensed" while the Groups panel takes the whole vertical space. So, at first, I thought the group panel should behave as the other ones. But when you collapse/expend the group tree, you do not want the panel to enlarge/shrink each time.
Following the same idea, I will not put the Add group button beneath the last group.
So, "Between Filter groups and All entries." OR "Between Groups and Filter groups"? I would say "Between Groups and Filter groups" because you need to create groups before filtering them.

Note: the Add group button is mostly here to help new users: when you are used to work with groups, it is more convenient to use a right-click on a group name (including the All entries group) because you can access all functions (including creating a sub-group).

@ChrisK91
Copy link

I just came here from the documentation, wondering why I'm unable to add a button. The documentation has a screenshot showing the button as a "plus" on the right https://docs.jabref.org/finding-sorting-and-cleaning-entries/groups . I was really wondering, why I'm unable to find it, until I found this issue.

@dimitrisdimos00
Copy link
Contributor

Hey I managed to push the button between groups and filter groups

@dimitrisdimos00
Copy link
Contributor

image

@dimitrisdimos00
Copy link
Contributor

shall I make a pr?

@Siedlerchr
Copy link
Member

Yes, please, that makes it easier for us to see the changes

@ChrisK91
Copy link

Maybe it's also an idea to use different styling? Visually, the "Search" and "Add group" text are equal to "No content in table". There is nothing indicating that these are buttons. Maybe a faint outline or different background color would help.

dimitrisdimos00 added a commit to dimitrisdimos00/jabref that referenced this issue Jan 24, 2022
@dimitrisdimos00
Copy link
Contributor

dimitrisdimos00 commented Jan 24, 2022

Yeah, I guess we can look into that too. Better open a new issue though.

@calixtus
Copy link
Member

Refs #4681

@ThiloteE
Copy link
Member Author

@ThiloteE
Copy link
Member Author

There was a lengthy discussion with devcall and #8462 (comment) was the proposed way forward.

@koppor
Copy link
Member

koppor commented Nov 7, 2022

Currently, hover is the way to go: koppor#632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment